fix(prefer-checked): don't flag aria-checked="mixed"#420
Merged
G-Rath merged 2 commits intotesting-library:mainfrom Feb 13, 2026
Merged
fix(prefer-checked): don't flag aria-checked="mixed"#420G-Rath merged 2 commits intotesting-library:mainfrom
aria-checked="mixed"#420G-Rath merged 2 commits intotesting-library:mainfrom
Conversation
Allow attribute rules to skip specific values (e.g. 'mixed') so tri-state aria attributes are not incorrectly flagged. Apply to prefer-checked to stop suggesting not.toBeChecked() for aria-checked='mixed'.
Verify aria-checked='mixed' is not flagged by prefer-checked.
shamrt-v
changed the title
3 tasks
G-Rath
changed the title
aria-checked="mixed"
G-Rath
approved these changes
Feb 13, 2026
Aesthermortis
added a commit
to Aesthermortis/eslint-plugin-jest-dom
that referenced
this pull request
May 4, 2026
Add generic attribute-value rule generation for replacing manual ARIA mixed-state assertions with semantic jest-dom matchers. - Add prefer-partially-checked for aria-checked="mixed" - Add prefer-partially-pressed for aria-pressed="mixed" - Reintroduce the all config for every exported rule - Keep partial-state rules out of the recommended preset - Add rule docs and split tests by matcher Upstream-Context: testing-library#43 Upstream-Context: testing-library#419 Upstream-Context: testing-library#420 Related-Context: testing-library/jest-dom#249 Related-Context: testing-library/jest-dom#203 Related-Context: testing-library/jest-dom#692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
excludeValuesoption tocreateBannedAttributeRulefactoryexcludeValues: ["mixed"]toprefer-checkedto stop incorrectly flaggingaria-checked="mixed"Why:
The
prefer-checkedrule incorrectly suggestsnot.toBeChecked()when it encounterstoHaveAttribute('aria-checked', 'mixed'). The value"mixed"is a valid third state foraria-checked(representing an indeterminate/partially-checked state) and should not be treated as falsy. The correct matcher for this case istoBePartiallyChecked(), which is outside the scope ofprefer-checked.How:
createBannedAttributeRulewith an optionalexcludeValuesparameter (defaults to[])toHaveAttribute/toHavePropertycall has a second argument matching an excluded value, the rule skips itexcludeValuesbehave identicallyChecklist: