fix: use file URL for esm import and remove node version check #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently supported node versions no longer need the check for esm import support. Signed-off-by: Chris. Webster <[email protected]>
The fully qualified path needs to be a URL type to work on Windows. Signed-off-by: Chris. Webster <[email protected]>
This was referenced Feb 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit does a little cleanup under the assumption import is always available now.
Currently supported node versions no longer need the check for esm import support.
The fully qualified path needs to be a URL type to work on Windows.
The fix addresses a problem found running the quibble CI for PR 89 on Windows.
The problem can be recreated on Windows by adding this test to
package.json:"test:safe:esm": "cd example/esm-node && npm test -- test/lib/dog-test.mjs:10",The recreate was not added to this patch series in case a different implementation is preferred.
Tested on Windows on both cmd and bash 'shells'.