refactor!: put reqwest behind http_wait feature#705
Merged
DDtKey merged 1 commit intoJul 23, 2024
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rukai
changed the title
DDtKey
changed the title
reqwest behind http_wait feature
DDtKey
reviewed
Jul 22, 2024
rukai
force-pushed
the
put_reqwest_behind_http_feature
branch
2 times, most recently
from
38c7864 to
45da8a3
Compare
DDtKey
reviewed
Jul 23, 2024
DDtKey
reviewed
Jul 23, 2024
DDtKey
left a comment
DDtKey
left a comment
Contributor
There was a problem hiding this comment.
Please, double check cargo doc result to ensure the feature is correctly shown.
Or keep as is if you don't have time, I'll prepare follow up PR then.
Thank you!
rukai
force-pushed
the
put_reqwest_behind_http_feature
branch
from
45da8a3 to
52483cd
Compare
Contributor
Author
|
Should be good now: |
DDtKey
reviewed
Jul 23, 2024
rukai
force-pushed
the
put_reqwest_behind_http_feature
branch
from
52483cd to
242d160
Compare
DDtKey
approved these changes
Jul 23, 2024
Contributor
|
Thanks for your contribution and quick response to comments! 🚀 |
Merged
DDtKey
pushed a commit
that referenced
this pull request
Jul 30, 2024
## 🤖 New release * `testcontainers`: 0.20.1 -> 0.21.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.21.0] - 2024-07-30 ### Details #### Bug Fixes - Don't assume docker host is a url ([#709](#709)) #### Miscellaneous Tasks - Bump the bollard group across 1 directory with 2 updates ([#710](#710)) #### Refactor - [❗] Put `reqwest` behind `http_wait` feature ([#705](#705)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Closes #711 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #704
I have no particular attachment to the
http_waitfeature name but it seems short and clear to me.