Change KurrentDB protocol from esdb to kurrentdb
#1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getConnectionStringnow:kurrentdb://by defaultesdb://if the image name containseventstoreQuestions for review
String matching: Should I use a stricter pattern like
eventstore/eventstoreinstead of just checking if the image name containseventstore?Compatibility concern: Looking at my tests,
KurrentDBContainercannot start with old EventStore images without overriding environment variables (the env prefix changed fromEVENTSTORE_toKURRENT_). Given this limitation, should we even bother with theesdb://fallback since the container won't work out of the box with EventStore images anyway?What are your thoughts @cristianrgreco?