Skip to content

Conversation

@botflux
Copy link
Contributor

@botflux botflux commented Jul 4, 2025

Changes

getConnectionString now:

  • Uses kurrentdb:// by default
  • Falls back to esdb:// if the image name contains eventstore

Questions for review

  1. String matching: Should I use a stricter pattern like eventstore/eventstore instead of just checking if the image name contains eventstore?

  2. Compatibility concern: Looking at my tests, KurrentDBContainer cannot start with old EventStore images without overriding environment variables (the env prefix changed from EVENTSTORE_ to KURRENT_). Given this limitation, should we even bother with the esdb:// fallback since the container won't work out of the box with EventStore images anyway?

What are your thoughts @cristianrgreco?

@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 74f174c
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6867d96be84c5f0008ef21dc
😎 Deploy Preview https://deploy-preview-1051--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@botflux botflux changed the title use esdb when the image contains 'eventstore' #1029 use esdb when the image contains 'eventstore' Jul 4, 2025
@cristianrgreco
Copy link
Collaborator

Compatibility concern: Looking at my tests, KurrentDBContainer cannot start with old EventStore images without overriding environment variables (the env prefix changed from EVENTSTORE_ to KURRENT_). Given this limitation, should we even bother with the esdb:// fallback since the container won't work out of the box with EventStore images anyway?

Great spot! My only reason for maintaining esdb was backward compatibility with eventstore, but if there isn't any (it was a major release after all) then it's not necessary. Looks like we can simply s/esdb/kurrentdb/. Thanks @botflux

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Jul 4, 2025
@botflux
Copy link
Contributor Author

botflux commented Jul 4, 2025

Done! Now kurrentdb:// is hardcoded.

@cristianrgreco cristianrgreco changed the title use esdb when the image contains 'eventstore' Change KurrentDB protocol from esdb to kurrentdb Jul 4, 2025
@cristianrgreco cristianrgreco merged commit 0d6250c into testcontainers:main Jul 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants