Skip to content

Conversation

@joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented May 22, 2025

Changes:

  • Restores codec to the pubsub sample code, using the global TextEncoder/TextDecoder
  • Adds compatibility with the "nats" scratch image used by the other NATS Testcontainers

The "nats" compatibility change is explained in #1009 (comment)

@netlify
Copy link

netlify bot commented May 22, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit dd74b23
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/682f9dcffaca6b0008dc1e01
😎 Deploy Preview https://deploy-preview-1011--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels May 23, 2025
@cristianrgreco cristianrgreco changed the title chore: add codec, scratch compatibility NATS: Add codec, scratch compatibility May 23, 2025
@cristianrgreco cristianrgreco merged commit b31eaca into testcontainers:main May 23, 2025
18 checks passed
@joebowbeer joebowbeer deleted the textencoder-1 branch May 23, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants