Skip to content

fix: skip unhealthy#2717

Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/skip-unhealthy
Aug 9, 2024
Merged

fix: skip unhealthy#2717
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/skip-unhealthy

Conversation

@stevenh
Copy link
Contributor

@stevenh stevenh commented Aug 8, 2024

Pass the right variable to skip unhealthy function in tests, so it actually functions.

Pass the right variable to skip unhealthy function in tests, so it
actually functions.
@stevenh stevenh requested a review from a team as a code owner August 8, 2024 18:52
@netlify
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit ba9edde
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b513e2944cf6000868c167
😎 Deploy Preview https://deploy-preview-2717--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

t.Cleanup(testProvider.RestoreReaperState)

SkipIfProviderIsNotHealthy(&testing.T{})
SkipIfProviderIsNotHealthy(t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM intensifies

@mdelapenya mdelapenya self-assigned this Aug 9, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 9, 2024
@mdelapenya mdelapenya merged commit fc4b264 into testcontainers:main Aug 9, 2024
mdelapenya added a commit that referenced this pull request Aug 12, 2024
* main:
  fix: readiness hook back off (#2718)
  fix: skip unhealthy (#2717)
  fix: filter context errors from log production (#2715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants