feat: Support configuring Docker API version #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
WalkthroughThis change introduces configurable Docker API version support across Testcontainers. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Settings as TestcontainersSettings
participant EnvConfig as EnvironmentConfiguration
participant PropsConfig as PropertiesFileConfiguration
participant AuthConfig as DockerEndpointAuthenticationConfiguration
participant Client as DockerApiClient
participant Docker as Docker Engine
User->>Settings: Access DockerApiVersion
Settings->>EnvConfig: GetDockerApiVersion()
alt Env var set
EnvConfig-->>Settings: Version
else Env var missing
Settings->>PropsConfig: GetDockerApiVersion()
alt Property set
PropsConfig-->>Settings: Version
else Property missing
Settings-->>Settings: Default 1.44
end
end
Settings->>AuthConfig: Version property
AuthConfig-->>Client: authConfig.Version
Client->>Docker: CreateClient(version)
Docker-->>Client: Configured client
Client-->>User: Success
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Areas requiring attention:
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-11-08T09:04:00.045ZApplied to files:
🧬 Code graph analysis (4)src/Testcontainers/Builders/DockerEndpointAuthenticationProvider.cs (1)
src/Testcontainers/Configurations/AuthConfigs/DockerEndpointAuthenticationConfiguration.cs (5)
src/Testcontainers/Clients/DockerApiClient.cs (5)
tests/Testcontainers.Tests/Unit/Containers/Unix/ProtectDockerDaemonSocketTest.cs (5)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
HofmeisterAn
deleted the
feature/allow-configuring-the-docker-api-version
branch
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Docker Engine v29 introduces breaking changes that make Testcontainers and the Docker.DotNet implementation incompatible. I had a quick chat with @eddumelendez, who mentioned that pinning the API to version
1.44, which is the most widely used and compatible version, works as a temporary workaround until Docker.DotNet and Testcontainers fully support the new version. This was also mentioned in the blog post referenced in the release notes.@KSlingerland It would be really helpful if you could test pinning the version as mentioned in the issue. After that, I think we can merge the PR and publish a new version quickly.
Why is it important?
Makes sure Testcontainers for .NET works with Docker Engine v29.
Related issues