Skip to content

Conversation

@verdie-g
Copy link
Contributor

What does this PR do?

Fix Milvus test container for v2.6+ following this script

https://github.com/milvus-io/milvus/blob/b1af0df9f34bb66ce414df7694cd082b96307596/scripts/standalone_embed.sh#L50

Why is it important?

The container wouldn't start. See milvus-io/milvus#45420.

@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit a88447c
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/6911b4d9000d0700084fc0b5
😎 Deploy Preview https://deploy-preview-1569--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

Summary by CodeRabbit

  • Chores
    • Updated Milvus container initialization to set standalone deployment mode by default.

Walkthrough

Adds the DEPLOY_MODE=STANDALONE environment variable to the Milvus container initialization within the Init() method of MilvusBuilder. This configures the container's deployment mode during setup.

Changes

Cohort / File(s) Change Summary
Milvus Environment Configuration
src/Testcontainers.Milvus/MilvusBuilder.cs
Adds DEPLOY_MODE=STANDALONE environment variable to container initialization in the Init() chain

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file with a minimal, additive change
  • Straightforward environment variable configuration
  • No complex logic or structural modifications

Poem

🐰 A Milvus hops with care,
Setting DEPLOY_MODE_STANDALONE in the air,
Through Init() chains it goes,
One little var that grows,
Deployment blooms with flair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description includes both mandatory sections (What and Why) with sufficient context, including relevant links to the Milvus repository and discussion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: setting DEPLOY_MODE=STANDALONE in the Milvus container initialization, which is the only modification in the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5517556 and a88447c.

📒 Files selected for processing (1)
  • src/Testcontainers.Milvus/MilvusBuilder.cs (1 hunks)

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Nov 10, 2025
@HofmeisterAn HofmeisterAn changed the title fix: set DEPLOY_MODE=STANDALONE for Milvus fix(Milvus): Set DEPLOY_MODE=STANDALONE (necessary for v2.6+) Nov 10, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HofmeisterAn HofmeisterAn merged commit c8ff7dd into testcontainers:develop Nov 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants