-
-
Notifications
You must be signed in to change notification settings - Fork 341
chore: Update test-framework to xUnit.net v3 #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update test-framework to xUnit.net v3 #1441
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tests/Testcontainers.Tests/Unit/Configurations/WaitUntilMessageIsLoggedTest.cs
Outdated
Show resolved
Hide resolved
HofmeisterAn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, if there's no major blocker, it's a good idea to switch to v3. Thanks.
tests/Testcontainers.Tests/Unit/Configurations/WaitUntilMessageIsLoggedTest.cs
Outdated
Show resolved
Hide resolved
90fa6b9 to
5f4c1fa
Compare
|
Thanks 🙇. |
|
This pull request is a nightmare for Rider users, see RIDER-121579 - Duplication of tests. 😕 I'll try to submit a follow-up pull request to address this. |
Interesting. I use Rider and did not experience this while authoring the PR or in other projects. Not sure if this means it is only related to v3 > 2.0.1, but then again I use the same XUnit version at work with Rider |
At least my work-Rider has "Enable Testing Platform support" disabled - maybe that's the reason it's not happening to me. I don't think I disabled it intentionally, though |
|
I don't have that problem either (tested on two different machines). "Enable Testing Platform support" is disabled too. |
|
I just refactored a test and added |

What does this PR do?
Currently all test-projects except
Testcontainers.XunitV3.Testsuse Xunit.Net v2. After this PR all test-projects exceptTestcontainers.Xunit.Testsuse Xunit.Net v3Why is it important?
I would expect that some day in the future Xunit.Net v2 will be discontinued. Also switching to Xunit.Net v3 means, that we can use all the new features like further Asserts and better test-cancellation. See also https://xunit.net/docs/getting-started/v3/whats-new for details
While I do think, that this should be done one day, it does not necessarily need to be today. On the other hand, I did not have problems using v3 so far (in other projects), and it will probably never be easier to switch anyway.