Skip to content

Conversation

@digital88
Copy link
Contributor

What does this PR do?

Adds OpenSearch testcontainers implementation.

Why is it important?

Currently there is no OpenSearch testcontainers implementation.

Related issues

Hopefully closes #1137

How to test this PR

tests/Testcontainers.OpenSearch.Tests

@netlify
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 1a4e120
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/683f58d834a1960008707e13
😎 Deploy Preview https://deploy-preview-1395--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@digital88
Copy link
Contributor Author

@HofmeisterAn Hello, please take a look.

@HofmeisterAn HofmeisterAn added enhancement New feature or request module An official Testcontainers module labels May 21, 2025
@digital88
Copy link
Contributor Author

I think this is ready for review

@HofmeisterAn
Copy link
Collaborator

Thanks for updating. I'll review it in the next days.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I finally had a time to review it. Overall, it looks good. I made a few adjustments for alignment and changed how the wait strategy is configured.

If we configure it using WithDisabledSecurity(bool), the order of method calls starts to matter, which we generally try to avoid. For example, if a user calls WithPassword(string) afterward, the readiness check will fail.

In cases where builder APIs have dependencies like this, we either use a dedicated method to handle it or apply the final configuration in Build().

I still need to review the tests tomorrow. If you're okay with the changes I made, we can go ahead and merge it then.

@digital88
Copy link
Contributor Author

Thanks for the PR! I finally had a time to review it. Overall, it looks good. I made a few adjustments for alignment and changed how the wait strategy is configured.

If we configure it using WithDisabledSecurity(bool), the order of method calls starts to matter, which we generally try to avoid. For example, if a user calls WithPassword(string) afterward, the readiness check will fail.

In cases where builder APIs have dependencies like this, we either use a dedicated method to handle it or apply the final configuration in Build().

I still need to review the tests tomorrow. If you're okay with the changes I made, we can go ahead and merge it then.

Hello. Thanks for review. Overall all changes look good, I appreciate you taking time to do it.

@HofmeisterAn HofmeisterAn changed the title add OpenSearch container and tests feat: Add OpenSearch module Jun 3, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙇.

@HofmeisterAn HofmeisterAn merged commit 46a0865 into testcontainers:develop Jun 4, 2025
77 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request module An official Testcontainers module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add OpenSearch Container

2 participants