Skip to content

fix: Retrieve logs since CreatedTime for UntilMessageIsLogged wait strategy #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HofmeisterAn merged 1 commit into from
Feb 28, 2025
Merged

fix: Retrieve logs since CreatedTime for UntilMessageIsLogged wait strategy #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Testcontainers/Configurations/WaitStrategies/UntilMessageIsLogged.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public UntilMessageIsLogged(Regex pattern)

public async Task<bool> UntilAsync(IContainer container)
{
var (stdout, stderr) = await container.GetLogsAsync(since: container.StoppedTime, timestampsEnabled: false)
var maxTime = container.StoppedTime > container.CreatedTime ? container.StoppedTime : container.CreatedTime;
var (stdout, stderr) = await container.GetLogsAsync(since: maxTime, timestampsEnabled: false)
.ConfigureAwait(false);

return _pattern.IsMatch(stdout) || _pattern.IsMatch(stderr);
Expand Down