Open
Conversation
feat: Updating notebooks to reflect new best practices
Collaborator
seanmacavaney
left a comment
seanmacavaney
left a comment
There was a problem hiding this comment.
Can we have some examples/documentation? A lot changed, and I can't tell from the PR how to use it now.
| Basic Workflows | ||
| ---------------- | ||
|
|
||
| .. how-to:: I want a first RAG baseline in a few lines. |
Collaborator
There was a problem hiding this comment.
Can reframe these as questions? E.g., How do I run a simple RAG baseline?
| Generic Reader | ||
| -------------------------- | ||
|
|
||
| ``Reader`` in the refactored prompt setup accepts either: |
Collaborator
There was a problem hiding this comment.
Let's not call it the "refactored prompt setup" -- this won't make sense to readers learning about this, since they don't know what it was before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces PromptTransformer / Concatenation with a purely Jinja-based solution