Support additional fields in Concatenator#39
Open
NamaWho wants to merge 1 commit intoterrierteam:mainfrom
Open
Support additional fields in Concatenator#39NamaWho wants to merge 1 commit intoterrierteam:mainfrom
NamaWho wants to merge 1 commit intoterrierteam:mainfrom
Conversation
Collaborator
|
LGTM, i'll let @Parry-Parry review too. |
Collaborator
|
Looks okay to me, @seanmacavaney any thoughts? if not we can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for passing additional fields through the concatenator to the reader module.
Use case:
This is useful for RAG benchmarks involving multiple choices, where the reader requires access to fields beyond the standard input (e.g., choices, question_type, etc.).