Skip to content

Conversation

@cloud-foundation-bot
Copy link
Collaborator

This PR was auto generated, please review for accuracy before merging

@comment-bot-dev
Copy link

comment-bot-dev commented Mar 14, 2021

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_documentation
    The documentation needs to be regenerated. Please run make generate_docs.
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/slo-generator/simple_example/README.md /tmp/tmp.92vBzSuO1g/generate_docs/workspace/examples/slo-generator/simple_example/README.md
22a23
> | bq\_location | Location of BQ dataset | `string` | `"US"` | no |
24c25
< | project\_id | Project id | `string` | n/a | yes |
---
> | project\_id | Project id | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/slo-generator/yaml_example/README.md /tmp/tmp.92vBzSuO1g/generate_docs/workspace/examples/slo-generator/yaml_example/README.md
22a23
> | bucket\_location | Bucket name for SLO configs and GCF code zips | `string` | `"US"` | no |
25c26
< | project\_id | Project id | `string` | n/a | yes |
---
> | project\_id | Project id | `any` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/cc @ocervell

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 4, 2021
@morgante morgante merged commit 6de1459 into master Jul 5, 2021
@release-please release-please bot mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants