Skip to content

Add support for 16 bit activations in ExpandDims operation. #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
May 24, 2024
Merged

Add support for 16 bit activations in ExpandDims operation. #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75bcb77
Add support for 16 bit activations in ExpandDims operation.
robertkamara May 20, 2024
0d958d1
Merge branch 'main' into expand_dims_int16
mergify[bot] May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tensorflow/lite/micro/kernels/expand_dims.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#include <cstdint>

#include "tensorflow/lite/c/common.h"
#include "tensorflow/lite/kernels/internal/tensor_ctypes.h"
#include "tensorflow/lite/kernels/kernel_util.h"
Expand Down Expand Up @@ -128,13 +130,18 @@ TfLiteStatus ExpandDimsEval(TfLiteContext* context, TfLiteNode* node) {
memCopyN(tflite::micro::GetTensorData<float>(output),
tflite::micro::GetTensorData<float>(input), flat_size);
} break;
case kTfLiteInt16: {
memCopyN(tflite::micro::GetTensorData<int16_t>(output),
tflite::micro::GetTensorData<int16_t>(input), flat_size);
} break;
case kTfLiteInt8: {
memCopyN(tflite::micro::GetTensorData<int8_t>(output),
tflite::micro::GetTensorData<int8_t>(input), flat_size);
} break;
default:
MicroPrintf(
"Expand_Dims only currently supports int8 and float32, got %d.",
"Expand_Dims only currently supports int8, int16 and float32, got "
"%d.",
input->type);
return kTfLiteError;
}
Expand Down
16 changes: 16 additions & 0 deletions tensorflow/lite/micro/kernels/expand_dims_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#include <cstdint>

#include "tensorflow/lite/c/builtin_op_data.h"
#include "tensorflow/lite/c/common.h"
#include "tensorflow/lite/micro/kernels/kernel_runner.h"
Expand Down Expand Up @@ -138,6 +140,20 @@ TF_LITE_MICRO_TEST(ExpandDimsPositiveAxisTest2) {
golden_data, output_data);
}

TF_LITE_MICRO_TEST(ExpandDimsPositiveAxisTest3) {
int16_t output_data[6];
int input_dims[] = {3, 3, 1, 2};
const int16_t input_data[] = {-1, 1, 2, -2, 0, 3};
const int16_t golden_data[] = {-1, 1, 2, -2, 0, 3};
int axis_dims[] = {1, 1};
const int32_t axis_data[] = {3};
int golden_dims[] = {1, 3, 1, 2};
int output_dims[] = {4, 3, 1, 2, 1};
tflite::testing::TestExpandDims<int16_t>(input_dims, input_data, axis_dims,
axis_data, golden_dims, output_dims,
golden_data, output_data);
}

TF_LITE_MICRO_TEST(ExpandDimsNegativeAxisTest4) {
int8_t output_data[6];
int input_dims[] = {3, 3, 1, 2};
Expand Down