Add code generator experiment#2162
Merged
mergify[bot] merged 3 commits intotensorflow:mainfrom Aug 10, 2023
Merged
Conversation
This PR creates the initial code generator scaffolding for performing inference without an interpreter. Currently, this does nothing other create a header and source file from Mako templates. Mako was chosen as a template engine due to existing dependency. BUG=b/295076487
advaitjain
requested changes
Aug 10, 2023
Member
advaitjain
left a comment
advaitjain
left a comment
There was a problem hiding this comment.
What do you think of making a top-level codegen directory instead of tensorflow/lite/micro/tools/codegen?
| """ Generate C/C++ inference code. """ | ||
| header_file = f"{output_name}.h" | ||
| model_data: ModelData = { | ||
| 'header_file': header_file, |
Contributor
Author
There was a problem hiding this comment.
Yeah, the generated source file will need to know where it's corresponding header is. Probably could have inferred it in the template from the model name, but that seemed like it could drift if we start including paths.
Contributor
Author
There was a problem hiding this comment.
Added header_file to the ModelData TypedDict
Contributor
Author
|
Top level codegen directory sounds good to me, lot less typing. :) |
Also adds header_file to the TypedDict
advaitjain
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates the initial code generator scaffolding for performing inference without an interpreter. Currently, this does nothing other create a header and source file from Mako templates. Mako was chosen as a template engine due to existing dependency.
BUG=b/295076487