Skip to content

Conversation

@hybridmuse
Copy link

@hybridmuse hybridmuse commented Mar 28, 2020

Fixes #2007


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hybridmuse
Copy link
Author

@googlebot I signed it

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gabor
Copy link

gabor commented Aug 5, 2020

is there any way to help with this?

@jameshfisher
Copy link
Contributor

Can someone take a look at this one? AFAICS, it's a simple fix to #2007 (which for some reason is closed, but the issue still exists)

@rthadur rthadur requested a review from annxingyuan October 21, 2020 13:55
@annxingyuan
Copy link
Contributor

Thank you @hybridmuse ! Would you mind also running yarn in the tfjs-core directory so we get an updated yarn.lock file as part of this PR?

cc @tafsiri

@tafsiri
Copy link
Contributor

tafsiri commented Oct 21, 2020

@annxingyuan given the age of this PR, would you want to push a commit to it with the updated package.json/lock file.

@tafsiri
Copy link
Contributor

tafsiri commented Oct 21, 2020

Also, @annxingyuan do we need these types here after the split out of the webgl backend?

@tafsiri
Copy link
Contributor

tafsiri commented Nov 30, 2020

Thanks for the contribution. I think this has been done in another PR.

@tafsiri tafsiri closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error with TypeScript 3.6

6 participants