Summary
quanticsgrids::DiscretizedGrid does not implement PartialEq, which forces downstream crates to write handwritten structural equality wrappers.
Why this matters
In BubbleTeaCI-rs, we currently wrap quanticsgrids::DiscretizedGrid and had to add a manual PartialEq implementation just to compare grids in tests and helper logic. That workaround is easy to get out of sync with the real grid semantics.
Requested change
Please add structural PartialEq support for quanticsgrids::DiscretizedGrid at the defining crate level (likely quanticsgrids-rs), then let downstream users rely on that instead of reimplementing equality locally.
Suggested equality fields
A strict structural comparison seems appropriate here, for example comparing:
rsvariable_nameslower_boundupper_boundbase- any other stored fields that affect grid semantics such as endpoint inclusion / index table
I do not think approximate float equality belongs in PartialEq; approximate checks can stay in tests or separate helper APIs.
Notes
This may need to be fixed in the quanticsgrids-rs dependency first and then pulled into tensor4all-rs. I'm opening the issue here because this is where the missing trait becomes visible in downstream integration work.
Summary
quanticsgrids::DiscretizedGriddoes not implementPartialEq, which forces downstream crates to write handwritten structural equality wrappers.Why this matters
In
BubbleTeaCI-rs, we currently wrapquanticsgrids::DiscretizedGridand had to add a manualPartialEqimplementation just to compare grids in tests and helper logic. That workaround is easy to get out of sync with the real grid semantics.Requested change
Please add structural
PartialEqsupport forquanticsgrids::DiscretizedGridat the defining crate level (likelyquanticsgrids-rs), then let downstream users rely on that instead of reimplementing equality locally.Suggested equality fields
A strict structural comparison seems appropriate here, for example comparing:
rsvariable_nameslower_boundupper_boundbaseI do not think approximate float equality belongs in
PartialEq; approximate checks can stay in tests or separate helper APIs.Notes
This may need to be fixed in the
quanticsgrids-rsdependency first and then pulled intotensor4all-rs. I'm opening the issue here because this is where the missing trait becomes visible in downstream integration work.