Skip to content

Add workflow versioning overrides - #1624

Merged
Quinn-With-Two-Ns merged 1 commit into
mainfrom
feat/child-workflow-versioning-override
Oct 2, 2026
Merged

Quinn-With-Two-Ns merged 1 commit into
mainfrom
feat/child-workflow-versioning-override

Conversation

@Quinn-With-Two-Ns

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Add workflow versioning overrides.

Why?

Users want to override the target version on a workflow, especially when doing pre-deployment testing.

Checklist

  1. Closes [Feature Request] Allow overriding of the Worker Deployment Version when invoking a Child Workflow #1057

  2. How was this tested:

  1. Any docs updates needed?

Note

Medium Risk
Changes worker deployment routing for client-started and child workflows; incorrect overrides could run code on the wrong build, though behavior is opt-in and gated by server version.

Overview
Adds VersioningOverride (pinned, auto-upgrade, and one-time) so callers can steer worker deployment routing without changing task-queue defaults.

Client starts: WorkflowStartOptions::versioning_override and WorkflowUpdateWithStartOptions::versioning_override are sent on normal start, signal-with-start, and update-with-start (pinned/auto-upgrade need Server 1.28+; one-time needs 1.32+).

Child workflows (experimental): ChildWorkflowOptions::versioning_override routes a child independently of its parent via the core StartChildWorkflowExecution command (Server 1.32+). Child start failures now surface InvalidVersioningOverride and NamespaceNotFound instead of collapsing into generic errors.

The same release also documents several unrelated fixes (stable temporalio-common codegen for sccache, autoscaled poller concurrency after cancel/timeout, local-activity replay grouping, sticky vs normal poll balancing, and workflow-task failure reporting/metrics).

Reviewed by Cursor Bugbot for commit a9ef2c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@Quinn-With-Two-Ns
Quinn-With-Two-Ns requested a review from a team as a code owner October 2, 2026 16:56
@chris-olszewski chris-olszewski self-assigned this Oct 2, 2026
Comment on lines +843 to +849
#[cfg(feature = "experimental")]
use temporalio_common_wasm::{
WorkerDeploymentVersion, protos::temporal::api::workflow::v1::versioning_override,
};

#[cfg(feature = "experimental")]
#[test]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important, but can be nice to just put tests that require experimental along with their imports into their own test submodule so we can have a single #[cfg(feature = "experimental)] on the containing module.

Comment on lines +784 to +789
/// Accepts a protobuf-encoded `coresdk.workflow_completion.WorkflowActivationCompletion`.
///
/// Child workflow versioning overrides are carried in
/// `coresdk.workflow_commands.StartChildWorkflowExecution.versioning_override`, so language SDKs
/// can configure child routing without a separate C ABI option. Requires Temporal Server 1.32.0
/// or later.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like an oddly specific callout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow overriding of the Worker Deployment Version when invoking a Child Workflow

2 participants