Repository navigation
Add workflow versioning overrides - #1624
Merged
Merged
Conversation
chris-olszewski
approved these changes
Oct 2, 2026
Comment on lines
+843
to
+849
| #[cfg(feature = "experimental")] | ||
| use temporalio_common_wasm::{ | ||
| WorkerDeploymentVersion, protos::temporal::api::workflow::v1::versioning_override, | ||
| }; | ||
|
|
||
| #[cfg(feature = "experimental")] | ||
| #[test] |
Member
There was a problem hiding this comment.
Not important, but can be nice to just put tests that require experimental along with their imports into their own test submodule so we can have a single #[cfg(feature = "experimental)] on the containing module.
Comment on lines
+784
to
+789
| /// Accepts a protobuf-encoded `coresdk.workflow_completion.WorkflowActivationCompletion`. | ||
| /// | ||
| /// Child workflow versioning overrides are carried in | ||
| /// `coresdk.workflow_commands.StartChildWorkflowExecution.versioning_override`, so language SDKs | ||
| /// can configure child routing without a separate C ABI option. Requires Temporal Server 1.32.0 | ||
| /// or later. |
Member
There was a problem hiding this comment.
This feels like an oddly specific callout
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add workflow versioning overrides.
Why?
Users want to override the target version on a workflow, especially when doing pre-deployment testing.
Checklist
Closes [Feature Request] Allow overriding of the Worker Deployment Version when invoking a Child Workflow #1057
How was this tested:
Note
Medium Risk
Changes worker deployment routing for client-started and child workflows; incorrect overrides could run code on the wrong build, though behavior is opt-in and gated by server version.
Overview
Adds
VersioningOverride(pinned, auto-upgrade, and one-time) so callers can steer worker deployment routing without changing task-queue defaults.Client starts:
WorkflowStartOptions::versioning_overrideandWorkflowUpdateWithStartOptions::versioning_overrideare sent on normal start, signal-with-start, and update-with-start (pinned/auto-upgrade need Server 1.28+; one-time needs 1.32+).Child workflows (experimental):
ChildWorkflowOptions::versioning_overrideroutes a child independently of its parent via the coreStartChildWorkflowExecutioncommand (Server 1.32+). Child start failures now surfaceInvalidVersioningOverrideandNamespaceNotFoundinstead of collapsing into generic errors.The same release also documents several unrelated fixes (stable
temporalio-commoncodegen for sccache, autoscaled poller concurrency after cancel/timeout, local-activity replay grouping, sticky vs normal poll balancing, and workflow-task failure reporting/metrics).Reviewed by Cursor Bugbot for commit a9ef2c9. Bugbot is set up for automated code reviews on this repo. Configure here.