Skip to content

Upgrade go.opentelemetry.io/otel/sdk to v1.40.0#2218

Merged
yuandrew merged 3 commits intotemporalio:masterfrom
yuandrew:otel-sdk-1-40-0
Mar 10, 2026
Merged

Upgrade go.opentelemetry.io/otel/sdk to v1.40.0#2218
yuandrew merged 3 commits intotemporalio:masterfrom
yuandrew:otel-sdk-1-40-0

Conversation

@yuandrew
Copy link
Contributor

@yuandrew yuandrew commented Mar 9, 2026

What was changed

Combined #2211, #2210, and #2209 into a single PR

Added a nil check for tests, now that EventuallyWithT runs immediately, instead of after a tick, stretchr/testify#1427

Fixed TestPinnedOverrideInWorkflowOptions test flake. An existing race, but potentially amplified by go 1.24.0 bump, which changed goroutine scheduling behavior. Fixed by retrying ExecuteWorkflow in an Eventually loop until the pinned verison is present.

Why?

https://cwe.mitre.org/data/definitions/426.html

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Note

Medium Risk
Primarily dependency/toolchain upgrades (notably OpenTelemetry) which can introduce subtle behavioral or compatibility changes; code changes are limited to test robustness.

Overview
Upgrades dependency sets across contrib/datadog, contrib/opentelemetry, and test modules, including OpenTelemetry (go.opentelemetry.io/otel/*) to v1.40.0, go.opentelemetry.io/auto/sdk to v1.2.1, and various supporting libs (e.g. testify, goleak, go-cmp, x/sys), updating go.sum accordingly.

Moves affected modules to Go 1.24 (and updates toolchain directives where present). Also hardens flaky tests: adds a nil guard around d.SearchAttributes in schedule integration assertions and retries starting a workflow with a pinned deployment version until the matching engine observes the poller.

Written by Cursor Bugbot for commit ec401ea. This will update automatically on new commits. Configure here.

@yuandrew yuandrew requested a review from a team as a code owner March 9, 2026 19:59
@yuandrew yuandrew merged commit 29de23f into temporalio:master Mar 10, 2026
39 of 44 checks passed
@yuandrew yuandrew deleted the otel-sdk-1-40-0 branch March 10, 2026 00:09
yuandrew added a commit that referenced this pull request Mar 10, 2026
yuandrew added a commit that referenced this pull request Mar 10, 2026
@yuandrew yuandrew restored the otel-sdk-1-40-0 branch March 10, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants