Closed
Conversation
Reintroduce evmone as an EVM interpreter option behind the 'evmone' build tag. Includes gas refund propagation from evmone to Go StateDB, and C memory allocation for all parameters passed across the CGO boundary.
tellabg
force-pushed
the
evm-one-reborn-with-keeper
branch
from
d6c798f to
e4bddea
Compare
Owner
Author
|
Closing — the real PR is ethereum#33833 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduce evmone as an EVM interpreter option behind the
evmonebuild tag.Changes
-tags evmone(default build uses Go interpreter)Testing
--cache.noprefetchflag (prefetcher has thread-safety issues with evmone callbacks)Known Issues
GODEBUG=cgocheck=2during nested EVM calls (workaround:GODEBUG=cgocheck=0)invalid receipt root hashbad blocks observed (under investigation)