Skip to content

Conversation

@l-qing
Copy link
Member

@l-qing l-qing commented Feb 19, 2025

  1. Adapt fields and methods in go template.
  2. Adapt gRPC server configuration to support self-signed certificates.

/kind feature

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 19, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 19, 2025
@enarha
Copy link
Contributor

enarha commented Feb 20, 2025

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 20, 2025
@l-qing l-qing force-pushed the feat/adapt-simple-ui-testing-tool branch from 621ffa1 to 42d5634 Compare June 24, 2025 14:48
@l-qing
Copy link
Member Author

l-qing commented Jun 24, 2025

/cc @khrm

@tekton-robot tekton-robot requested a review from khrm June 24, 2025 14:49
@l-qing l-qing force-pushed the feat/adapt-simple-ui-testing-tool branch from 42d5634 to c6689b2 Compare July 27, 2025 11:56
@khrm
Copy link
Contributor

khrm commented Aug 12, 2025

Sorry. I didn't notice this. Will review today.

@khrm khrm requested a review from Copilot August 12, 2025 15:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adapts a simple UI testing tool to work with updated protobuf definitions and adds support for secure gRPC connections using self-signed certificates.

  • Updates Go template to use .Data.Type instead of .Data.TypeUrl for protobuf message types
  • Simplifies textproto function to use native string representation instead of complex unmarshaling
  • Adds configurable gRPC client with TLS certificate support and command-line flags

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tools/simpleui/templates/records.html Updates template field reference from TypeUrl to Type
tools/simpleui/template.go Simplifies textproto function and updates imports for new protobuf types
tools/simpleui/main.go Adds TLS support, command-line flags, and configurable gRPC connection

}
return prototext.Format(m), nil
func textproto(a *pb.Any) string {
return a.String()
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The textproto function has been changed from returning (string, error) to just string, removing error handling. This could mask potential issues when converting protobuf Any messages to string representation. Consider maintaining error handling or documenting why errors are no longer possible.

Copilot uses AI. Check for mistakes.
1. Adapt fields and methods in go template.
2. Adapt gRPC server configuration to support self-signed certificates.
@l-qing l-qing force-pushed the feat/adapt-simple-ui-testing-tool branch from c6689b2 to 7423d18 Compare October 28, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants