-
Notifications
You must be signed in to change notification settings - Fork 87
feat: adapt simple UI testing tool #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
621ffa1 to
42d5634
Compare
|
/cc @khrm |
42d5634 to
c6689b2
Compare
|
Sorry. I didn't notice this. Will review today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adapts a simple UI testing tool to work with updated protobuf definitions and adds support for secure gRPC connections using self-signed certificates.
- Updates Go template to use
.Data.Typeinstead of.Data.TypeUrlfor protobuf message types - Simplifies textproto function to use native string representation instead of complex unmarshaling
- Adds configurable gRPC client with TLS certificate support and command-line flags
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/simpleui/templates/records.html | Updates template field reference from TypeUrl to Type |
| tools/simpleui/template.go | Simplifies textproto function and updates imports for new protobuf types |
| tools/simpleui/main.go | Adds TLS support, command-line flags, and configurable gRPC connection |
| } | ||
| return prototext.Format(m), nil | ||
| func textproto(a *pb.Any) string { | ||
| return a.String() |
Copilot
AI
Aug 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The textproto function has been changed from returning (string, error) to just string, removing error handling. This could mask potential issues when converting protobuf Any messages to string representation. Consider maintaining error handling or documenting why errors are no longer possible.
1. Adapt fields and methods in go template. 2. Adapt gRPC server configuration to support self-signed certificates.
c6689b2 to
7423d18
Compare
/kind feature
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes