Skip to content

Remove deprecated // +build directive from most files #9118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

Remove deprecated // +build directive from most files #9118

merged 1 commit into from
Nov 4, 2025

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 30, 2025

Changes

  • It will soon error out, and we already use the //go:build directive.
  • It doesn't touch generated files (need to be fixed upstream)

/cc @waveywaves @aThorp96

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 30, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Oct 30, 2025

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: aThorp96.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

  • It will soon error out, and we already use the //go:build directive.
  • It doesn't touch generated files (need to be fixed upstream)

/cc @waveywaves @aThorp96

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2025
@vdemeester
Copy link
Member Author

vdemeester commented Oct 30, 2025

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 30, 2025
aThorp96
aThorp96 reviewed Oct 30, 2025
View reviewed changes
tekton/release-pipeline.yaml
- name: publish-images
runAfter: [unit-tests, build]
taskRef:
resolver: git
Copy link
Member

@aThorp96 aThorp96 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change. Should it be included in a separate PR?

Copy link
Member Author

@vdemeester vdemeester Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh crap, yes it shouldn't be there at all 😂

@vdemeester
Copy link
Member Author

vdemeester commented Oct 31, 2025

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025
@vdemeester
Remove deprecated // +build directive from most files
b1ea040 
- It will soon error out, and we already use the `//go:build`
directive.
- It doesn't touch generated files (need to be fixed upstream)

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

vdemeester commented Oct 31, 2025

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025
waveywaves
waveywaves approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@tekton-robot tekton-robot merged commit f978f7f into tektoncd:main Nov 4, 2025
43 of 47 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Nov 4, 2025
@vdemeester vdemeester deleted the fix-go-build-tags branch November 4, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waveywaves waveywaves waveywaves approved these changes

+1 more reviewer

@aThorp96 aThorp96 aThorp96 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@waveywaves waveywaves

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdemeester @tekton-robot @waveywaves @aThorp96