Skip to content

[release-v1.3.x] fix(#8940): token-authentication header typo in git resolver #8947 #9115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2025
Merged

[release-v1.3.x] fix(#8940): token-authentication header typo in git resolver #8947 #9115

merged 4 commits into from
Nov 7, 2025
+33 −32

Conversation

@aThorp96
Copy link
Member

@aThorp96 aThorp96 commented Oct 29, 2025 •
edited
Loading

This fix was merged into main hours before 1.3.0 was released so it was not included in the release branch release-v1.3.x, and never got cherry-picked after the fact. It was included in v1.0.x, v1.4.x, and v1.5.x.

Note that the e2e tests included in the original patch depended on the the Gitea tests which included but disabled in v1.3.2 here.

/assign @vdemeester
/assign @waveywaves

Bug fix: Before this change, there was a regression in which the git resolver was not authenticating with the provided `gitToken` and `gitTokenKey`, breaking the git resolver's http token-based auth. After this change, all git operations performed by the git resolver use the provided `gitToken` for remote authentication.

@aThorp96
fix(tektoncd#8940): Fix token-authentication header in git resolver
835a19c 
The header specified for the git resolver's http auth contained a typo
leading to authentication tokens not being properly sent to the remote.

Additionally, this change fixes the outdated token-authenticated git
resolver example and adds an e2e regression test for authenticated git
cloning.

Resolves: tektoncd#8940
Resolves: https://issues.redhat.com/browse/SRVKP-8260
@aThorp96
chore: fix unit test action name
9380bd6
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 29, 2025
@tekton-robot tekton-robot requested review from dibyom and jerop October 29, 2025 18:07
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2025
@vdemeester
Copy link
Member

vdemeester commented Oct 29, 2025

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@vdemeester @aThorp96
tests: pdate csi-node-driver-registrar image reference
971b6d8 
Seems like the quay.io image is either gone, or at least sometimes
gone. The repository for this is
https://github.com/kubernetes-csi/node-driver-registrar, the image
referenced there is from k8s.gcr.io, so let's use it.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Nov 3, 2025

New changes are detected. LGTM label has been removed.

@aThorp96
Copy link
Member Author

aThorp96 commented Nov 3, 2025 •
edited
Loading

Also includes the CI image reference fix from #9089, to fix the broken CI on this release branch

@aThorp96
Copy link
Member Author

aThorp96 commented Nov 4, 2025

@vdemeester can this be retested?

@vdemeester
Copy link
Member

vdemeester commented Nov 5, 2025

The actions actions/upload-artifact@v4, ko-build/[email protected], and chainguard-dev/actions/kind-diag@main are not allowed in tektoncd/pipeline because all actions must be from a repository owned by tektoncd, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: alexellis/arkade-get@, alexellis/setup-arkade@, chainguard-dev/actions/kind-diag@, chainguard-dev/actions/setup-kind@, chartboost/ruff-action@, docker://agilepathway/pull-request-label-checker:, fgrosse/go-coverage-report@, get-woke/woke-action@, golangci/golangci-lint-action@, helm/kind-action@, imjasonh/setup-crane@, imjasonh/setup-ko@, jitterbit/get-changed-files@, ko-build/setup-ko@, peter-evans/create-or-update-comment@, peter-evans/create-pull-request@, peter-evans/slash-command-dispatch@, tj-actions/changed-files@. All actions must also be pinned to a full-length commit SHA.

@aThorp96
Copy link
Member Author

aThorp96 commented Nov 6, 2025

🫠 holy Github Runner
image

@vdemeester vdemeester merged commit e5ed49f into tektoncd:release-v1.3.x Nov 7, 2025
84 of 110 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@jerop jerop Awaiting requested review from jerop

Assignees

@vdemeester vdemeester

@waveywaves waveywaves

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aThorp96 @vdemeester @tekton-robot @waveywaves @AlanGreene