Skip to content

Enable Param Substitution in StepAction resolver reference params #7872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

Enable Param Substitution in StepAction resolver reference params #7872

merged 1 commit into from
Apr 12, 2024

Conversation

@chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Apr 10, 2024 •
edited
Loading

Fixes #7865.

This PR allows param substitution in Step Ref Resolver params. This is already possible in TaskRef and PipelineRef as highlighted in the above issue. This was missed in the original design. I think of this as a bug since based on TaskRef and PipelineRef, it feels like a loose end. For consistency, we should be able to perform these substitutions.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Enable Param Substitution in StepAction resolver reference params

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 10, 2024
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2024
@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 10, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 88.9% -3.7

@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 10, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 88.9% -3.7

@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Apr 10, 2024

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2024
@chitrangpatel chitrangpatel added this to the Pipelines v0.59 milestone Apr 10, 2024
@chitrangpatel chitrangpatel force-pushed the step-action-resolver-param-substitutions branch from 01f2335 to 7fac7ef Compare April 10, 2024 17:47
@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 10, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 88.9% -3.7

@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 10, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 88.9% -3.7

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Apr 10, 2024

/lgtm

@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 10, 2024

@aaron-prindle: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Yongxuanzhang
Yongxuanzhang approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the yaml to pass build test

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@chitrangpatel chitrangpatel force-pushed the step-action-resolver-param-substitutions branch from 7fac7ef to a2bfb62 Compare April 11, 2024 14:19
@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 11, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 94.0% 1.5

@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 11, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 94.0% 1.5

@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Apr 11, 2024

/test pull-tekton-pipeline-beta-integration-tests

@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Apr 11, 2024

/test /test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 11, 2024

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test /test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel chitrangpatel reopened this Apr 11, 2024
@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 11, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 94.0% 1.5

@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 11, 2024

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 94.0% 1.5

vdemeester
vdemeester approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@tekton-robot
Copy link
Collaborator

tekton-robot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit b70d30f into tektoncd:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jerop jerop Awaiting requested review from jerop

Assignees

@vdemeester vdemeester

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Pipelines v0.59

Development

Successfully merging this pull request may close these issues.

Allow param substitution in StepAction Reference Resolver Params

5 participants

@chitrangpatel @tekton-robot @aaron-prindle @vdemeester @Yongxuanzhang