bumping some dependencies #2571

vdemeester · 2020-05-07T13:53:02Z

Changes

This bumps a bunch of our dependencies, each one separated in a commit (in case of revert is required, …)

/cc @sbwsg @afrittoli @bobcatfish
/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Bump some dependencies
- github.com/pkg/errors v0.8.1 -> v0.9.1
- github.com/hashicorp/go-multierror v1.0.0 -> 1.1.0
- github.com/hashicorp/golang-lru v0.5.3 -> v0.5.4
- github.com/jenkins-x/go-scm: v1.5.79 -> v1.5.117
- go.opencensus.io: v0.22.1 -> v0.22.3
- go.uber.org/zap v1.13.0 -> v1.15.0

vdemeester · 2020-05-07T14:33:14Z

    TestPullRequest/github-default: e2e_test.go:97: starting HTTP proxy on 127.0.0.1:35319
    TestPullRequest/github-default: e2e_test.go:100: Environment vars: [PULL_PULL_SHA=66078f426243a3a7abfc738fa2c2db62d68b1e19 KUBERNETES_SERVICE_PORT_HTTPS=443 PULL_NUMBER=2571 DECK_PORT_80_TCP_PORT=80 REGION=us-central1 KUBERNETES_SERVICE_PORT=443 DECK_PORT_80_TCP=tcp://10.55.250.236:80 JOB_TYPE=presubmit CLUSTER_NAME=tpipeline-e2e-cls1258394483817451522 GOFLAGS=-mod=vendor HOSTNAME=123abe9d-906a-11ea-845f-0a580a3400e8 KUBE_GKE_NETWORK=tpipeline-e2e-net1258394483817451522 HOOK_PORT_8888_TCP_PROTO=tcp KO_DATA_PATH=/home/prow/go/src/github.com/tektoncd/pipeline/.git ENTRYPOINT_OPTIONS={"timeout":7200000000000,"grace_period":15000000000,"artifact_dir":"/logs/artifacts","args":["/usr/local/bin/entrypoint.sh","--scenario=kubernetes_execute_bazel","--clean","--job=pull-tekton-pipeline-integration-tests","--repo=github.com/tektoncd/pipeline=master:5d780b47757d2c94d9c3b67fecfcbdd25ef16753,2571:66078f426243a3a7abfc738fa2c2db62d68b1e19","--root=/go/src","--service-account=/etc/test-account/service-account.json","--upload=gs://tekton-prow/pr-logs","--","--","./test/presubmit-tests.sh","--integration-tests"],"process_log":"/logs/process-log.txt","marker_file":"/logs/marker-file.txt","metadata_file":"/logs/artifacts/metadata.json"} KUBECTL=./cluster/kubectl.sh --match-server-version HOOK_SERVICE_PORT=8888 HOOK_SERVICE_HOST=10.55.254.214 CLOUDSDK_CORE_DISABLE_PROMPTS=1 TIDE_PORT=tcp://10.55.243.29:80 PULL_BASE_REF=master KUBERNETES_CONFORMANCE_TEST=yes TIDE_PORT_80_TCP_PORT=80 HOOK_PORT_8888_TCP=tcp://10.55.254.214:8888 GOBIN=/usr/local/go/bin DOCKER_IN_DOCKER_IPV6_ENABLED=false PWD=/home/prow/go/src/github.com/tektoncd/pipeline/test/pullrequest SOURCE_DATE_EPOCH=1588856806 HOOK_PORT_8888_TCP_ADDR=10.55.254.214 GOOGLE_APPLICATION_CREDENTIALS=/etc/test-account/service-account.json CLUSTER_API_VERSION=1.15.11-gke.11 BUILD_NUMBER=1258394483817451522 KUBERNETES_RELEASE=v1.15.11-gke.11 NODE_INSTANCE_GROUP=gke-tpipeline-e2e-cls125-default-pool-65de48d3-grp REPO_NAME=pipeline E2E_CLUSTER_ZONE= DOCKER_IN_DOCKER_ENABLED=false DISABLE_YAML_LINTING=1 HOME=/root ARTIFACTS=/logs/artifacts TIDE_PORT_80_TCP_PROTO=tcp KUBERNETES_CONFORMANCE_PROVIDER=gke PULL_BASE_SHA=5d780b47757d2c94d9c3b67fecfcbdd25ef16753 KUBERNETES_PORT_443_TCP=tcp://10.55.240.1:443 KUBERNETES_SKIP_CONFIRM=y CLOUDSDK_API_ENDPOINT_OVERRIDES_CONTAINER=https://container.googleapis.com/ DISABLE_MD_LINK_CHECK=1 PROW_JOB_ID=123abe9d-906a-11ea-845f-0a580a3400e8 JOB_NAME=pull-tekton-pipeline-integration-tests HOOK_PORT_8888_TCP_PORT=8888 GINKGO_PARALLEL_NODES=1 KUBE_GCE_INSTANCE_PREFIX=gke-tpipeline-e2e-cls1258394483817451522 TIDE_SERVICE_PORT=80 DECK_SERVICE_PORT=80 TIDE_PORT_80_TCP_ADDR=10.55.243.29 KUBE_NODE_OS_DISTRIBUTION=cos CLOUDSDK_CORE_PRINT_UNHANDLED_TRACEBACKS=1 KUBERNETES_DOWNLOAD_TESTS=y NODE_OS_DISTRIBUTION=cos DECK_PORT_80_TCP_ADDR=10.55.250.236 KUBE_RUNTIME_CONFIG=batch/v2alpha1=true DECK_SERVICE_HOST=10.55.250.236 SHLVL=4 KUBERNETES_SKIP_CREATE_CLUSTER=y PULL_REFS=master:5d780b47757d2c94d9c3b67fecfcbdd25ef16753,2571:66078f426243a3a7abfc738fa2c2db62d68b1e19 KUBERNETES_PORT_443_TCP_PROTO=tcp KUBERNETES_PORT_443_TCP_ADDR=10.55.240.1 JOB_SPEC={"type":"presubmit","job":"pull-tekton-pipeline-integration-tests","buildid":"1258394483817451522","prowjobid":"123abe9d-906a-11ea-845f-0a580a3400e8","refs":{"org":"tektoncd","repo":"pipeline","repo_link":"https://github.com/tektoncd/pipeline","base_ref":"master","base_sha":"5d780b47757d2c94d9c3b67fecfcbdd25ef16753","base_link":"https://github.com/tektoncd/pipeline/commit/5d780b47757d2c94d9c3b67fecfcbdd25ef16753","pulls":[{"number":2571,"author":"vdemeester","sha":"66078f426243a3a7abfc738fa2c2db62d68b1e19","link":"https://github.com/tektoncd/pipeline/pull/2571","commit_link":"https://github.com/tektoncd/pipeline/pull/2571/commits/66078f426243a3a7abfc738fa2c2db62d68b1e19","author_link":"https://github.com/vdemeester"}]}} REPO_OWNER=tektoncd KUBECONFIG=/tmp/gke-kubecfg594472802 KO_DOCKER_REPO=gcr.io/tekton-prow-8/tpipeline-e2e-img TIDE_PORT_80_TCP=tcp://10.55.243.29:80 KUBE_CONFIG_FILE=config-test.sh DECK_PORT=tcp://10.55.250.236:80 DECK
_PORT_80_TCP_PROTO=tcp KUBERNETES_SERVICE_HOST=10.55.240.1 KUBERNETES_PORT=tcp://10.55.240.1:443 KUBERNETES_PORT_443_TCP_PORT=443 E2E_CLUSTER_REGION=us-central1 TIDE_SERVICE_HOST=10.55.243.29 HOOK_PORT=tcp://10.55.254.214:8888 PATH=/home/prow/go/bin:/usr/local/go/bin:/google-cloud-sdk/bin:/workspace:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin DISABLE_MD_LINTING=1 KUBERNETES_RELEASE_URL=https://storage.googleapis.com/gke-release/kubernetes/release BUILD_ID=1258394483817451522 PROJECT=tekton-prow-8 DEBIAN_FRONTEND=noninteractive     TERM=xterm OLDPWD=/home/prow/go/src/github.com/tektoncd/pipeline/kubernetes GOPATH=/home/prow/go _=/usr/local/go/bin/go AUTH_TOKEN=hunter2 http_proxy=127.0.0.1:35319]
    TestPullRequest/github-default: e2e_test.go:103: 
        ########################################
        # download
        ########################################
    TestPullRequest/github-default: e2e_test.go:103: /usr/local/go/bin/go run github.com/tektoncd/pipeline/cmd/pullrequest-init -mode=download -path=/tmp/TestPullRequest774168316/github-default -url=http://github.com/wlynch/test/pulls/1
127.0.0.1:43232 GET http://api.github.com/repos/wlynch/test/pulls/1
127.0.0.1:43232 GET http://api.github.com/repos/wlynch/test/statuses/db165c3a71dc45d096aebd0f49f07ec565ad1e08?
127.0.0.1:43232 GET http://api.github.com/repos/wlynch/test/issues/1/comments?
127.0.0.1:43232 GET http://api.github.com/repos/wlynch/test/issues/1/labels?
    TestPullRequest/github-default: e2e_test.go:107: diff -r testdata/golden/comments/494418247.json /tmp/TestPullRequest774168316/github-default/comments/494418247.json
        1c1
        < {"ID":494418247,"Body":"test comment","Author":{"Login":"wlynch","Name":"","Email":"","Avatar":"https://avatars3.githubusercontent.com/u/1844673?v=4","Link":"","Created":"0001-01-01T00:00:00Z","Updated":"0001-01-01T00:00:00Z"},"Link":"https://github.com/wlynch/test/pull/1#issuecomment-494418247","Created":"2019-05-21T14:34:46Z","Updated":"2019-05-21T14:34:46Z"}
        \ No newline at end of file
        ---
        > {"ID":494418247,"Body":"test comment","Author":{"ID":0,"Login":"wlynch","Name":"","Email":"","Avatar":"https://avatars3.githubusercontent.com/u/1844673?v=4","Link":"","Created":"0001-01-01T00:00:00Z","Updated":"0001-01-01T00:00:00Z"},"Link":"https://github.com/wlynch/test/pull/1#issuecomment-494418247","Created":"2019-05-21T14:34:46Z","Updated":"2019-05-21T14:34:46Z"}
        \ No newline at end of file
        diff -r testdata/golden/pr.json /tmp/TestPullRequest774168316/github-default/pr.json
        1c1
        < {"Number":1,"Title":"test","Body":"","Labels":[{"ID":0,"URL":"https://api.github.com/repos/wlynch/test/labels/my-label","Name":"my-label","Description":"","Color":"ededed"}],"Sha":"db165c3a71dc45d096aebd0f49f07ec565ad1e08","Ref":"refs/pull/1/head","Source":"dev","Target":"master","Base":{"Ref":"master","Sha":"c7becbd850add03130ec9797600711b0d6ecaf34","Repo":{"ID":"27785726","Namespace":"wlynch","Name":"test","FullName":"wlynch/test","Perm":{"Pull":false,"Push":false,"Admin":false},"Branch":"master","Private":false,"Clone":"https://github.com/wlynch/test.git","CloneSSH":"[email protected]:wlynch/test.git","Link":"https://github.com/wlynch/test","Created":"2014-12-09T20:32:35Z","Updated":"2020-01-10T18:34:39Z"}},"Head":{"Ref":"dev","Sha":"db165c3a71dc45d096aebd0f49f07ec565ad1e08","Repo":{"ID":"27785726","Namespace":"wlynch","Name":"test","FullName":"wlynch/test","Perm":{"Pull":false,"Push":false,"Admin":false},"Branch":"master","Private":false,"Clone":"https://github.com/wlynch/test.git","CloneSSH":"[email protected]:wlynch/test.git","Link":"https://github.com/wlynch/test","Created":"2014-12-09T20:32:35Z","Updated":"2020-01-10T18:34:39Z"}},"Fork":"wlynch/test","Link":"https://github.com/wlynch/test/pull/1.diff","State":"open","Closed":false,"Draft":false,"Merged":false,"Mergeable":false,"Rebaseable":false,"MergeableState":"","MergeSha":"0b5320d67796506663ef41e5c5fa0b7bf8a06f58","Author":{"Login":"wlynch","Name":"","Email":"","Avatar":"https://avatars3.githubusercontent.com/u/1844673?v=4","Link":"https://github.com/wlynch","Created":"0001-01-01T00:00:00Z","Updated":"0001-01-01T00:00:00Z"},"Assignees":null,"Milestone":{"Number":0,"ID":0,"Title":"","Description":"","Link":"","State":""},"Created":"2018-05-15T16:22:34Z","Updated":"2019-12-26T16:37:05Z"}
        \ No newline at end of file
        ---
        > {"Number":1,"Title":"test","Body":"","Labels":[{"ID":0,"URL":"https://api.github.com/repos/wlynch/test/labels/my-label","Name":"my-label","Description":"","Color":"ededed"}],"Sha":"db165c3a71dc45d096aebd0f49f07ec565ad1e08","Ref":"refs/pull/1/head","Source":"dev","Target":"master","Base":{"Ref":"master","Sha":"c7becbd850add03130ec9797600711b0d6ecaf34","Repo":{"ID":"27785726","Namespace":"wlynch","Name":"test","FullName":"wlynch/test","Perm":{"Pull":false,"Push":false,"Admin":false},"Branch":"master","Private":false,"Clone":"https://github.com/wlynch/test.git","CloneSSH":"[email protected]:wlynch/test.git","Link":"https://github.com/wlynch/test","Created":"2014-12-09T20:32:35Z","Updated":"2020-01-10T18:34:39Z"}},"Head":{"Ref":"dev","Sha":"db165c3a71dc45d096aebd0f49f07ec565ad1e08","Repo":{"ID":"27785726","Namespace":"wlynch","Name":"test","FullName":"wlynch/test","Perm":{"Pull":false,"Push":false,"Admin":false},"Branch":"master","Private":false,"Clone":"https://github.com/wlynch/test.git","CloneSSH":"[email protected]:wlynch/test.git","Link":"https://github.com/wlynch/test","Created":"2014-12-09T20:32:35Z","Updated":"2020-01-10T18:34:39Z"}},"Fork":"wlynch/test","Link":"https://github.com/wlynch/test/pull/1.diff","State":"open","Closed":false,"Draft":false,"Merged":false,"Mergeable":false,"Rebaseable":false,"MergeableState":"","MergeSha":"0b5320d67796506663ef41e5c5fa0b7bf8a06f58","Author":{"ID":1844673,"Login":"wlynch","Name":"","Email":"","Avatar":"https://avatars3.githubusercontent.com/u/1844673?v=4","Link":"https://github.com/wlynch","Created":"0001-01-01T00:00:00Z","Updated":"0001-01-01T00:00:00Z"},"Assignees":null,"Milestone":{"Number":0,"ID":0,"Title":"","Description":"","Link":"","State":""},"Created":"2018-05-15T16:22:34Z","Updated":"2019-12-26T16:37:05Z"}
        \ No newline at end of file
        
    TestPullRequest/github-default: e2e_test.go:111: 
        ########################################
        # modify
        ########################################
    TestPullRequest/github-default: e2e_test.go:114: 
        ########################################
        # upload
        ########################################
    TestPullRequest/github-default: e2e_test.go:114: /usr/local/go/bin/go run github.com/tektoncd/pipeline/cmd/pullrequest-init -mode=upload -path=/tmp/TestPullRequest774168316/github-default -url=http://github.com/wlynch/test/pulls/1
127.0.0.1:43234 GET http://api.github.com/repos/wlynch/test/issues/1/labels?
127.0.0.1:43234 GET http://api.github.com/repos/wlynch/test/statuses/db165c3a71dc45d096aebd0f49f07ec565ad1e08?
127.0.0.1:43234 GET http://api.github.com/repos/wlynch/test/issues/1/comments?

Looks like a legit failure 🙃

Signed-off-by: Vincent Demeester <[email protected]>

chmouel · 2020-05-11T15:30:30Z

/lgtm

dibyom · 2020-05-11T19:25:52Z

/approve

tekton-robot · 2020-05-11T19:25:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from a user, afrittoli and bobcatfish May 7, 2020 13:53

tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2020

vdemeester added 3 commits May 11, 2020 13:24

github.com/pkg/errors v0.8.1 -> v0.9.1

1439b55

Signed-off-by: Vincent Demeester <[email protected]>

github.com/hashicorp/go-multierror v1.0.0 -> 1.1.0

a5dc57d

Signed-off-by: Vincent Demeester <[email protected]>

github.com/hashicorp/golang-lru v0.5.3 -> v0.5.4

ab47fd6

Signed-off-by: Vincent Demeester <[email protected]>

vdemeester force-pushed the bump-some-deps branch 3 times, most recently from 379c339 to 0bf52c2 Compare May 11, 2020 13:04

vdemeester added 3 commits May 11, 2020 17:23

github.com/jenkins-x/go-scm: v1.5.79 -> v1.5.117

8b3dad6

Signed-off-by: Vincent Demeester <[email protected]>

go.opencensus.io: v0.22.1 -> v0.22.3

518d4e4

Signed-off-by: Vincent Demeester <[email protected]>

go.uber.org/zap v1.13.0 -> v1.15.0

6dfe9fc

Signed-off-by: Vincent Demeester <[email protected]>

vdemeester force-pushed the bump-some-deps branch from 0bf52c2 to 6dfe9fc Compare May 11, 2020 15:23

tekton-robot assigned chmouel May 11, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020

tekton-robot merged commit 6038676 into tektoncd:master May 11, 2020

vdemeester deleted the bump-some-deps branch May 11, 2020 20:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bumping some dependencies #2571

bumping some dependencies #2571

Uh oh!

vdemeester commented May 7, 2020

Uh oh!

vdemeester commented May 7, 2020

Uh oh!

chmouel commented May 11, 2020

Uh oh!

dibyom commented May 11, 2020

Uh oh!

tekton-robot commented May 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bumping some dependencies #2571

bumping some dependencies #2571

Uh oh!

Conversation

vdemeester commented May 7, 2020

Changes

Submitter Checklist

Reviewer Notes

Release Notes

Uh oh!

vdemeester commented May 7, 2020

Uh oh!

chmouel commented May 11, 2020

Uh oh!

dibyom commented May 11, 2020

Uh oh!

tekton-robot commented May 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants