-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Expected Behavior
When the taskrun controller fails to update a taskrun status or labels/annotations, it should emit an event to signal this condition, similar to what the pipelinerun controller does.
Actual Behavior
An error is returned, so that the key is requeued, but not event is emitted.
Steps to Reproduce the Problem
pipeline/pkg/reconciler/taskrun/taskrun.go
Line 208 in b435bd9
return multierror.Append(err, c.updateStatusLabelsAndAnnotations(tr, original)).ErrorOrNil()
Additional Info
- Tekton Pipeline version:
v0.12.0
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.