Skip to content

Emit event when failing to update a taskrun #2522

@afrittoli

Description

@afrittoli

Expected Behavior

When the taskrun controller fails to update a taskrun status or labels/annotations, it should emit an event to signal this condition, similar to what the pipelinerun controller does.

Actual Behavior

An error is returned, so that the key is requeued, but not event is emitted.

Steps to Reproduce the Problem

  1. return multierror.Append(err, c.updateStatusLabelsAndAnnotations(tr, original)).ErrorOrNil()

Additional Info

  • Tekton Pipeline version:

v0.12.0

Metadata

Metadata

Assignees

Labels

kind/featureCategorizes issue or PR as related to a new feature.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions