Add support to pass CSI workspace#1794
Merged
Merged
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
vinamra28
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
Member
Author
|
/retest |
vdemeester
reviewed
Nov 23, 2022
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
I think we should document this a bit more somehow, as initially it wasn't really clear to me that it would load a file. Other than this, looks good to me 👍🏼
Member
Author
yeah makes sense. Will be adding this and improving the code a little bit more |
vinamra28
force-pushed
the
csi-driver-support
branch
from
45dca48 to
e4c86a5
Compare
Member
Author
|
/retest |
vinamra28
force-pushed
the
csi-driver-support
branch
from
91c0b2c to
b8d30ff
Compare
vinamra28
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
vinamra28
force-pushed
the
csi-driver-support
branch
from
b8d30ff to
8293379
Compare
piyush-garg
reviewed
Dec 7, 2022
piyush-garg
reviewed
Dec 7, 2022
Member
Author
|
/retest |
vinamra28
force-pushed
the
csi-driver-support
branch
from
946a4fb to
51023ed
Compare
Member
Author
Member
Author
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
Member
Author
|
/retest |
vinamra28
force-pushed
the
csi-driver-support
branch
from
51023ed to
509171c
Compare
Member
Author
|
/retest |
Contributor
|
@vinamra28 seems like this is breaking because of 0.43 release |
Since Pipelines version v0.38.0, an user can pass CSI Volume as a workspace. A sample CSI file can look like ```yaml driver: secrets-store.csi.k8s.io readOnly: true volumeAttributes: secretProviderClass: "vault-database" ``` This requires feature flag to be alpha. Once feature flag is enabled user can pass in `tkn` start like ```sh $ tkn pipeline start foobar -w=csiFile=csi.yaml ``` Signed-off-by: vinamra28 <jvinamra776@gmail.com>
vinamra28
force-pushed
the
csi-driver-support
branch
from
509171c to
e9a8ad8
Compare
Contributor
|
/lgtm |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Since Pipelines version v0.38.0, an user can pass CSI Volume
as a workspace. A sample CSI file can look like
This requires feature flag to be alpha. Once feature flag is enabled
user can pass in
tknstart likecloses #1668
Signed-off-by: vinamra28 jvinamra776@gmail.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes