Add few reference notes in debbuild readme#1772
Merged
tekton-robot merged 1 commit intoNov 7, 2022
Merged
Conversation
At the time of doing patch release v0.25.1, the build at launchpad failed with the error ``` + cat debian/VERSION + VERSION=0.25.1 + go build -mod=vendor -v -o obj-x86_64-linux-gnu/bin/tkn -ldflags -X github.com/tektoncd/cli/pkg/cmd/version.clientVersion=0.25.1 ./cmd/tkn build flag -mod=vendor only valid when using modules make[1]: *** [debian/rules:17: override_dh_auto_build] Error 1 make[1]: Leaving directory '/<<PKGBUILDDIR>>' make: *** [debian/rules:14: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 -------------------------------------------------------------------------------- ``` So adding the notes in Readme for future reference. Signed-off-by: vinamra28 <jvinamra776@gmail.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
Member
Author
|
/retest |
vdemeester
approved these changes
Nov 3, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
/test all |
Contributor
|
/retest |
1 similar comment
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
At the time of doing patch release v0.25.1, the build at launchpad failed with the error
So adding the notes in Readme for future reference.
Signed-off-by: vinamra28 jvinamra776@gmail.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes