Cancel PipelineRuns using Cancelled status#1554
Merged
Merged
Conversation
With TEP-0058, PipelineRunCancelled was deprecated and was replaced by Cancelled. Cancelled is still behind feature flag but it's behaviour resembles with PipelineRunCancelled. In this patch, we'll first try to cancel the PipelineRun with Cancelled status, if it fails with the error: feature flags needs to be enabled, then try cancelling with the deprecated status. Signed-off-by: vinamra28 <jvinamra776@gmail.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
Contributor
|
The following is the coverage report on the affected files.
|
Member
Author
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
Author
|
/retest |
Contributor
|
/lgtm |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
pradeepitm12
added a commit
that referenced
this pull request
Jun 6, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 6, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 6, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 6, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 6, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 7, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46 null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 7, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46 null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 7, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46 null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11 null | [Pradeep Kumar] fix unit-test in release pipeline | 2022/06/07-08:24 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Jun 7, 2022
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26 #1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50 #1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26 null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15 #1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44 #1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44 #1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12 #1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16 #1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49 #1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49 null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49 null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47 null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41 null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49 null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26 null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24 null | [Pradeep Kumar] fix go test | 2022/06/01-17:24 null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25 null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45 null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45 null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45 null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45 null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45 null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45 null | [Shubham] Get rid of antlr | 2022/06/03-15:45 null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58 null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19 null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19 null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03 null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46 null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11 null | [Pradeep Kumar] fix unit-test in release pipeline | 2022/06/07-08:24 null | [Pradeep Kumar] increase storage to 1Gi | 2022/06/07-10:46 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
With TEP-0058, PipelineRunCancelled was deprecated and was replaced by
Cancelled. Cancelled is still behind feature flag but it's behaviour
resembles with PipelineRunCancelled.
In this patch, we'll first try to cancel the PipelineRun with Cancelled
status, if it fails with the error: feature flags needs to be enabled,
then try cancelling with the deprecated status in order to make it
backward compatible.
closes #1553
Signed-off-by: vinamra28 jvinamra776@gmail.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes