This will fix the version command failing for chain and operator#1542
Merged
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
piyush-garg
force-pushed
the
fix_version
branch
from
89d3f18 to
56d8086
Compare
tekton-robot
added
size/S
Contributor
|
The following is the coverage report on the affected files.
|
pradeepitm12
approved these changes
Mar 23, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vinamra28
reviewed
Mar 23, 2022
piyush-garg
force-pushed
the
fix_version
branch
from
56d8086 to
d71e535
Compare
tkn version command is failing for cmponents like chains and operator but working for pipelines and triggers. The reason is retreiving version from configmap was failing and pipeline and triggers have backup logic to fetch version from deployments and hence it was working for them. For configmap we were checking the not found error but it was returning the permission error and hence it was not able to iterate through all namespaces. This will fix the proper error checking
piyush-garg
force-pushed
the
fix_version
branch
from
d71e535 to
fc8069b
Compare
Contributor
|
The following is the coverage report on the affected files.
|
Contributor
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
/hold |
tekton-robot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tkn version command is failing for cmponents like chains and operator but
working for pipelines and triggers. The reason is retreiving version from
configmap was failing and pipeline and triggers have backup logic to fetch version
from deployments and hence it was working for them.
For configmap we were checking the not found error but it was returning the
permission error and hence it was not able to iterate through all
namespaces. This will fix the proper error checking
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes