Skip to content

Conversation

@vampire-yuta
Copy link

@vampire-yuta vampire-yuta commented Mar 7, 2025

Changes

Add args '--create-namespace' to helm-upgrade-from-repo task.
Why I create this PR, If namespace is none, fail task.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot
Copy link

Hi @vampire-yuta. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2025
@tekton-robot
Copy link

Catlin Output
FILE: task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
ERROR: Resource path is invalid; expected path: task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --create-namespace --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                                           ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                                                  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..fb9dfdf 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..951cf42 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -48,4 +48,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --create-namespace --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..fb9dfdf 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..877c4ad 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -4,7 +4,7 @@ kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -48,4 +48,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --create-namespace --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"

@tekton-robot
Copy link

Catlin Output
FILE: task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/oci-cli/0.1/oci-cli.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --create-namespace --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                                           ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                                                  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@vampire-yuta vampire-yuta changed the title Update helm upgrade from repo Update helm upgrade from repo to 0.4 Mar 7, 2025
@fhopfensperger
Copy link
Member

Hey @vampire-yuta
Thanks for the PR, I think it’s should be a parameter instead of hard coding it.
Sometimes you dont want to create the namespace for testing purposes.

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..fb9dfdf 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..a34c9a8 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -4,7 +4,7 @@ kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..0d8a066 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -19,6 +19,8 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--create-namespace --force --timeout 10m0s"
 ---
 apiVersion: tekton.dev/v1beta1
 kind: PipelineRun

@tekton-robot
Copy link

Catlin Output
FILE: task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
FILE: task/jib-gradle/0.1/jib-gradle.yaml
WARN : Step "build-and-push" uses image "gcr.io/cloud-builders/gradle@sha256:797c9936cf33fc30d82a54437541d7ea7f7825c93e3237a89d254b9bc40b0898"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/oci-cli/0.1/oci-cli.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..8a24eba 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +22,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..a34c9a8 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -4,7 +4,7 @@ kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..0d8a066 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -19,6 +19,8 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--create-namespace --force --timeout 10m0s"
 ---
 apiVersion: tekton.dev/v1beta1
 kind: PipelineRun

@tekton-robot
Copy link

Catlin Output
FILE: task/gitleaks/0.1/gitleaks.yaml
WARN : Step "fetch-config-file" references "$(params.config_file_url)" directly from its script block. For reliability and security, consider putting the param into an environment variable of the Step and accessing that environment variable in your script instead.
FILE: task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
FILE: task/jib-gradle/0.1/jib-gradle.yaml
WARN : Step "build-and-push" uses image "gcr.io/cloud-builders/gradle@sha256:797c9936cf33fc30d82a54437541d7ea7f7825c93e3237a89d254b9bc40b0898"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/oci-cli/0.1/oci-cli.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@vampire-yuta
Copy link
Author

vampire-yuta commented Mar 8, 2025

@fhopfensperger
Thank you, your comment 😄
Thats' right.

I thinked adding upgrade_extra_params params than adding params "--create-namespace" .
Because it is usefull, when adding various params.

I use as reference simirar implemental.

- name: upgrade_extra_params
description: "Extra parameters passed for the helm upgrade command"
default: ""

@fhopfensperger
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2025
@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..8a24eba 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +22,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..a34c9a8 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -4,7 +4,7 @@ kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..62067f3 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -19,6 +19,8 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--force"
 ---
 apiVersion: tekton.dev/v1beta1
 kind: PipelineRun

@tekton-robot
Copy link

Catlin Output
FILE: task/gitleaks/0.1/gitleaks.yaml
WARN : Step "fetch-config-file" references "$(params.config_file_url)" directly from its script block. For reliability and security, consider putting the param into an environment variable of the Step and accessing that environment variable in your script instead.
FILE: task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
FILE: task/jib-gradle/0.1/jib-gradle.yaml
WARN : Step "build-and-push" uses image "gcr.io/cloud-builders/gradle@sha256:797c9936cf33fc30d82a54437541d7ea7f7825c93e3237a89d254b9bc40b0898"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/jib-gradle/0.2/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.3/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/jib-gradle/0.4/jib-gradle.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/oci-cli/0.1/oci-cli.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 15:
      }" > $HOME/init-script.gradle
           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      }" > "$HOME"/init-script.gradle


In jib-gradle-build-and-push line 20:
  --init-script=$HOME/init-script.gradle \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --init-script="$HOME"/init-script.gradle \


In jib-gradle-build-and-push line 21:
  --gradle-user-home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  --gradle-user-home="$HOME"/.gradle \


In jib-gradle-build-and-push line 22:
  -Dgradle.user.home=$HOME/.gradle \
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Dgradle.user.home="$HOME"/.gradle \


In jib-gradle-build-and-push line 23:
  -Duser.home=$HOME \
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  -Duser.home="$HOME" \


In jib-gradle-build-and-push line 24:
  -Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
                                ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 25:
  -Djib.to.image=$(params.IMAGE) \
                 ^-------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 26:
  -Djib.outputPaths.digest=$(workspaces.source.path)/$(params.DIRECTORY)/image-digest
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-digest-to-results line 2:
cat $(workspaces.source.path)/$(params.DIRECTORY)/image-digest | tee $(results.IMAGE_DIGEST.path)
    ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
    ^-- SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                              ^-----------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                     ^--------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

WARN : step: jib-gradle is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jib-gradle-build-and-push line 27:
  $(params.EXTRA_ARGS)
  ^------------------^ SC2046 (warning): Quote this to prevent word splitting.


In jib-gradle-build-and-push line 28:
echo $(params.IMAGE) | tee $(results.IMAGE_URL.path)
     ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
     ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                           ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

Comment on lines +5 to +6
## Install the Task

Copy link
Member

@vinamra28 vinamra28 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please update this section or remove as I can see that there is another section which talks about the same thing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section is updated.
The following has been added for reference. because this README is recentry added.

https://github.com/tektoncd/catalog/blob/main/task/42crunch-api-security-audit/0.3/README.md?plain=1

## Install the Task
Install `helm-upgrade-from-repo` task:
```
kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
```

app.kubernetes.io/version: "0.4"
annotations:
tekton.dev/categories: Deployment
tekton.dev/pipelines.minVersion: "0.12.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's upgrade this version to something latest > v0.50.x

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix pipeline latest version.

tekton.dev/categories: Deployment
tekton.dev/pipelines.minVersion: "1.4.0"

https://github.com/tektoncd/pipeline/releases/tag/v1.4.0

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..8a24eba 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +22,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..84cba72 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -1,10 +1,10 @@
 # This Task will do a helm upgrade based on the given helm repo and chart
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..1d9a22b 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -1,5 +1,5 @@
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Pipeline
 metadata:
   name: helm-upgrade-test-pipeline
@@ -19,6 +19,8 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--force"
 ---
 apiVersion: tekton.dev/v1beta1
 kind: PipelineRun

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.3/42crunch-api-security-audit.yaml
FILE: task/ai-code-review/0.1/ai-code-review.yaml
FILE: task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In yq-yq-script line 14:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..8a24eba 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +22,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..84cba72 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -1,10 +1,10 @@
 # This Task will do a helm upgrade based on the given helm repo and chart
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..1d9a22b 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -1,5 +1,5 @@
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Pipeline
 metadata:
   name: helm-upgrade-test-pipeline
@@ -19,6 +19,8 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--force"
 ---
 apiVersion: tekton.dev/v1beta1
 kind: PipelineRun

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.3/42crunch-api-security-audit.yaml
FILE: task/ai-code-review/0.1/ai-code-review.yaml
FILE: task/codecov/0.1/codecov.yaml
WARN : Step "codecov-run" uses image "ghcr.io/tektoncd/plumbing/test-runner@sha256:44aa00796831a4ed5586152058dd96a6d14174b8a4ea9fcae663fb37f72c9454"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/codecov/0.2/codecov.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In yq-yq-script line 14:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..8a24eba 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +22,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..84cba72 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -1,10 +1,10 @@
 # This Task will do a helm upgrade based on the given helm repo and chart
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
     tekton.dev/pipelines.minVersion: "0.12.1"
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..84d75ab 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -1,5 +1,5 @@
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Pipeline
 metadata:
   name: helm-upgrade-test-pipeline
@@ -19,8 +19,10 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--force"
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
   name: helm-upgrade-test-pipeline-run

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.3/42crunch-api-security-audit.yaml
FILE: task/ai-code-review/0.1/ai-code-review.yaml
FILE: task/codecov/0.1/codecov.yaml
WARN : Step "codecov-run" uses image "ghcr.io/tektoncd/plumbing/test-runner@sha256:44aa00796831a4ed5586152058dd96a6d14174b8a4ea9fcae663fb37f72c9454"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/codecov/0.2/codecov.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In yq-yq-script line 14:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..8a24eba 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -11,7 +11,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +22,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..26c13bf 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -1,13 +1,13 @@
 # This Task will do a helm upgrade based on the given helm repo and chart
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
-    tekton.dev/pipelines.minVersion: "0.12.1"
+    tekton.dev/pipelines.minVersion: "1.4.0"
     tekton.dev/tags: helm
     tekton.dev/platforms: "linux/amd64,linux/s390x,linux/ppc64le,linux/arm64"
 spec:
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..84d75ab 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -1,5 +1,5 @@
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Pipeline
 metadata:
   name: helm-upgrade-test-pipeline
@@ -19,8 +19,10 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--force"
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
   name: helm-upgrade-test-pipeline-run

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.3/42crunch-api-security-audit.yaml
FILE: task/ai-code-review/0.1/ai-code-review.yaml
FILE: task/codecov/0.1/codecov.yaml
WARN : Step "codecov-run" uses image "ghcr.io/tektoncd/plumbing/test-runner@sha256:44aa00796831a4ed5586152058dd96a6d14174b8a4ea9fcae663fb37f72c9454"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/codecov/0.2/codecov.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In yq-yq-script line 14:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

@tekton-robot
Copy link

Diff between version 0.3 and 0.4
diff --git a/task/helm-upgrade-from-repo/0.3/README.md b/task/helm-upgrade-from-repo/0.4/README.md
index 22e914d..f6fd255 100644
--- a/task/helm-upgrade-from-repo/0.3/README.md
+++ b/task/helm-upgrade-from-repo/0.4/README.md
@@ -4,6 +4,12 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 
 ## Install the Task
 
+Install `helm-upgrade-from-repo` task:
+
+```
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
+```
+
 #### Workspaces
 
 * **source**: A [Workspace](https://github.com/tektoncd/pipeline/blob/main/docs/workspaces.md) volume containing the helm chart.
@@ -11,7 +17,7 @@ These tasks will install / upgrade a helm chart into your Kubernetes / OpenShift
 ### helm install / upgrade from repo
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.3/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade-from-repo/0.4/raw
 ```
 
 #### Parameters
@@ -22,6 +28,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/helm-upgrade
 - **release_namespace**: The namespace in which the release is to be installed (*default: ""*)
 - **overwrite_values**: The values to be overwritten (*default: ""*)
 - **helm_image**: The helm image which should be used (default: lachlanevenson/k8s-helm:v3.5.0)
+- **upgrade_extra_params**: Extra parameters passed for the helm upgrade command (*default: ""*)
 
 #### Platforms
 
diff --git a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
index 0343bbc..26c13bf 100644
--- a/task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
+++ b/task/helm-upgrade-from-repo/0.4/helm-upgrade-from-repo.yaml
@@ -1,13 +1,13 @@
 # This Task will do a helm upgrade based on the given helm repo and chart
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: helm-upgrade-from-repo
   labels:
-    app.kubernetes.io/version: "0.3"
+    app.kubernetes.io/version: "0.4"
   annotations:
     tekton.dev/categories: Deployment
-    tekton.dev/pipelines.minVersion: "0.12.1"
+    tekton.dev/pipelines.minVersion: "1.4.0"
     tekton.dev/tags: helm
     tekton.dev/platforms: "linux/amd64,linux/s390x,linux/ppc64le,linux/arm64"
 spec:
@@ -35,6 +35,9 @@ spec:
     - name: helm_image
       description: "Specify a specific helm image"
       default: "docker.io/lachlanevenson/k8s-helm@sha256:0a068ae407e21d1836c6a89a1e9e81af1e55fa56890998e33d5caabdbb51e77b" # tag: v3.10.2
+    - name: upgrade_extra_params
+      description: "Extra parameters passed for the helm upgrade command"
+      default: ""
   steps:
     - name: upgrade-from-repo
       image: $(params.helm_image)
@@ -48,4 +51,4 @@ spec:
         echo adding updating repo...
         helm repo update
         echo installing helm chart...
-        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
+        helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
diff --git a/task/helm-upgrade-from-repo/0.3/tests/run.yaml b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
index d728495..84d75ab 100644
--- a/task/helm-upgrade-from-repo/0.3/tests/run.yaml
+++ b/task/helm-upgrade-from-repo/0.4/tests/run.yaml
@@ -1,5 +1,5 @@
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Pipeline
 metadata:
   name: helm-upgrade-test-pipeline
@@ -19,8 +19,10 @@ spec:
           value: helm-repo-sample
         - name: overwrite_values
           value: autoscaling.enabled=false,autoscaling.maxReplicas=3
+        - name: upgrade_extra_params
+          value: "--force"
 ---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: PipelineRun
 metadata:
   name: helm-upgrade-test-pipeline-run

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.3/42crunch-api-security-audit.yaml
FILE: task/ai-code-review/0.1/ai-code-review.yaml
FILE: task/codecov/0.1/codecov.yaml
WARN : Step "codecov-run" uses image "ghcr.io/tektoncd/plumbing/test-runner@sha256:44aa00796831a4ed5586152058dd96a6d14174b8a4ea9fcae663fb37f72c9454"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde
FILE: task/codecov/0.2/codecov.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In yq-yq-script line 14:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...

@vampire-yuta
Copy link
Author

I fixed all comments.
Please check it 😄

@vdemeester
Copy link
Member

/approve
@vampire-yuta can you rebase your PR for the CI to run ?
(sorry for the delay 🙏🏼 )

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants