Skip to content

Test Socks proxy in supported Faraday adapters #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 20, 2019
Merged

Test Socks proxy in supported Faraday adapters #7

merged 10 commits into from
Sep 20, 2019

Conversation

@technoweenie
Copy link
Owner

@technoweenie technoweenie commented Jun 13, 2019 •
edited
Loading

This was referenced Jun 13, 2019
Merged
Open
@technoweenie
Copy link
Owner Author

technoweenie commented Sep 20, 2019

Merging this even though the Faraday PR hasn't merged yet. The socks proxy stuff is now unchecked by default. You can test it with:

# rebuild 'tests' image with correct Faraday and Socksify gem versions
$ FARADAY_GEM_REF=7cf2e05c3cdee2a71b01e3cede99549a910227d4          \
  FARADAY_SOCKSIFY_GEM_REF=dae610084b4cebd0af92731dbf29f3dd9b9fd9d6 \
  docker-compose build tests

# run tests
$ TEST_PROTO=socks_proxy TEST_ADAPTER=net_http docker-compose run tests

# optional: rebuild 'tests' image with latest versions of Faraday and Socksify
$ docker-compose build tests

@technoweenie technoweenie merged commit dbd6c40 into master Sep 20, 2019
@technoweenie technoweenie deleted the socks branch September 20, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@technoweenie