Skip to content

Vision improvements#61

Open
minhlpnguyen wants to merge 8 commits intomainfrom
vision-pose
Open

Vision improvements#61
minhlpnguyen wants to merge 8 commits intomainfrom
vision-pose

Conversation

@minhlpnguyen
Copy link
Collaborator

@minhlpnguyen minhlpnguyen commented Oct 21, 2024

What else should I add? Created a method for filtering individual targets, unsure if it works better

@minhlpnguyen minhlpnguyen linked an issue Oct 21, 2024 that may be closed by this pull request
1 task
@minhlpnguyen
Copy link
Collaborator Author

@jkleiber @linglejack06 should a filter by target distance be added? this would require writing our own pose estimator class.
A method in Camera.java sorts pose estimations into high uncertainty versus low uncertainty based on average distance and angle from targets; this doesn't weight individual targets differently within a pose estimation but does weight overall poses when considering effect on localization

Copy link
Contributor

@aidnem aidnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the absolute values for the pitch suggestion, this looks fine to me.
Could we also add roll filtering?


for (PhotonTrackedTarget target : targets) {
if (target.getPoseAmbiguity() < VisionConstants.maximumAmbiguity
&& target.getPitch() < VisionConstants.maximumPitch) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an absolute value so that if pitch is too positive or too negative it'll reject both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is there any reason to do this here and not in the filterPhotonPose method (or we could do it in both places)?
I'm not necessarily asking for you to change it, I'm just curious about the reasoning behind putting it here vs. somewhere else.

@minhlpnguyen minhlpnguyen requested a review from aidnem October 23, 2024 23:38
@minhlpnguyen
Copy link
Collaborator Author

I added adjustments to variance calculating- could you see if it actually makes any logical sense? thank you!

@minhlpnguyen
Copy link
Collaborator Author

Should errors based off of distance be calculated based on distance alone or x and y components of distance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vision integration

2 participants