Skip to content

Conversation

@WillGibson
Copy link
Collaborator

It occurred to me that we could reduced security risk by removing unused dependencies...

➜ npx depcheck       
Unused dependencies
* chalk
* commander
* needle
* proxy-agent
* xmlbuilder2

Some of those were false positives because, like Stryker, depcheck does not check markdown-link-check because it has no file extension.

package.json Outdated
"eslint": "^9.14.0",
"expect.js": "^0.3.1",
"express": "^4.21.1",
"globals": "^15.12.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in

export default [
but maybe it comes with the eslint import

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that comes with eslint/eslintrc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import globals from "globals";

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated
"eslint": "^9.14.0",
"expect.js": "^0.3.1",
"express": "^4.21.1",
"globals": "^15.12.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import globals from "globals";

"needle": "^3.3.1",
"progress": "^2.0.3",
"proxy-agent": "^6.4.0",
"xmlbuilder2": "^3.1.1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only removed one unused dependency in the end ;-)

@BaseMax
Copy link
Collaborator

BaseMax commented Apr 8, 2025

This branch has conflicts that must be resolved

@WillGibson

@WillGibson
Copy link
Collaborator Author

@BaseMax Merged in master and resolved conflicts.

@BaseMax BaseMax merged commit f002bfb into master Apr 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants