-
Notifications
You must be signed in to change notification settings - Fork 136
chore(deps): Remove unused dependencies #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
| "eslint": "^9.14.0", | ||
| "expect.js": "^0.3.1", | ||
| "express": "^4.21.1", | ||
| "globals": "^15.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used in
markdown-link-check/eslint.config.mjs
Line 4 in f6bc588
| export default [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that comes with eslint/eslintrc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
markdown-link-check/eslint.config.mjs
Line 2 in f6bc588
| import globals from "globals"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
Outdated
| "eslint": "^9.14.0", | ||
| "expect.js": "^0.3.1", | ||
| "express": "^4.21.1", | ||
| "globals": "^15.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
markdown-link-check/eslint.config.mjs
Line 2 in f6bc588
| import globals from "globals"; |
| "needle": "^3.3.1", | ||
| "progress": "^2.0.3", | ||
| "proxy-agent": "^6.4.0", | ||
| "xmlbuilder2": "^3.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only removed one unused dependency in the end ;-)
|
|
@BaseMax Merged in |
It occurred to me that we could reduced security risk by removing unused dependencies...
Some of those were false positives because, like Stryker, depcheck does not check markdown-link-check because it has no file extension.