no deprecation warning if custom_parent_classes==[]#93
Open
brchristian wants to merge 1 commit into
Open
Conversation
rafaelfranca
approved these changes
Mar 24, 2017
rafaelfranca
left a comment
rafaelfranca
left a comment
There was a problem hiding this comment.
Oh, excellent finding! Thank you for opening the pr.
|
👍 Would love to see this merged in. My test suite gets spammed with these deprecation messages atm! |
|
Same thing here! 👍 Good work, guys. |
|
Please merge this in :). |
|
Is there a way to pull this into the gem locally and use it? |
|
Merge, please =) |
|
Merge possible? |
1 task
|
Merge please! 👍 |
|
We still need a merge....But on another note - Please optimize the embedded queries to minimize the the chance of receiving an n+1 query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #89 (comment) and in some of the issues like #91, the current
masterversion is issuing unnecessary deprecation warnings whencustom_parent_classes == [].Merging #89 will make this PR moot, because that refactors away the
custom_parent_classesobject entirely. That would be my personal recommendation.But, if there is hesitation to merge #89 for whatever reason, then we can at least merge this in the meantime and remove some of those unnecessary warnings. We could then aim to merge #89 at some later point in time.