refactor: Fix deprecations and fix return type of getCard() #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some deprecations triggered in php 8.4 (source)
The function getCard() can return null if no data is found. So I specified the return type and added a test.
There is still some deprecations on some attributes :
Deprecated: Creation of dynamic property TCGdex\Model\Set::$abbreviation is deprecatedDeprecated: Creation of dynamic property TCGdex\Model\Serie::$firstSet is deprecatedDeprecated: Creation of dynamic property TCGdex\Model\Serie::$lastSet is deprecatedAs they are more complex types, this is not included in this PR