Skip to content

Conversation

@clussiana
Copy link
Contributor

This PR fixes some deprecations triggered in php 8.4 (source)

The function getCard() can return null if no data is found. So I specified the return type and added a test.

There is still some deprecations on some attributes :

  • Deprecated: Creation of dynamic property TCGdex\Model\Set::$abbreviation is deprecated
  • Deprecated: Creation of dynamic property TCGdex\Model\Serie::$firstSet is deprecated
  • Deprecated: Creation of dynamic property TCGdex\Model\Serie::$lastSet is deprecated

As they are more complex types, this is not included in this PR

@codecov
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (383f7ef) to head (44c5f7c).
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
- Coverage     95.15%   92.85%   -2.30%     
- Complexity       90      103      +13     
============================================
  Files            10       13       +3     
  Lines           227      266      +39     
============================================
+ Hits            216      247      +31     
- Misses           11       19       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aviortheking
Copy link
Member

Hi, thanks for the PR, I'll look at the others deprecations in #95

@Aviortheking Aviortheking merged commit 77a67d3 into tcgdex:master Jan 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants