Test that string comparison is per-code-unit#4457
Merged
Conversation
The Ecma-262 specification describes string comparison as comparing lexicographically a string's code units. This is different from comparing by code points (see the readme to the [compare strings by codepoint proposal](https://github.com/tc39/proposal-compare-strings-by-codepoint)). However, the existing string comparison tests describe the spec's behavior as comparing by code points (which is wrong), and do not include any tests covering lone surrogates or characters greater than U+FFFF, which is when the difference appears. This patch fixes those descriptions, and adds some such missing tests.
Ms2ger
approved these changes
Apr 18, 2025
Contributor
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Those files could use a 21st century rewrite...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ecma-262 specification describes string comparison as comparing lexicographically a string's code units. This is different from comparing by code points (see the readme to the compare strings by codepoint proposal).
However, the existing string comparison tests describe the spec's behavior as comparing by code points (which is wrong), and do not include any tests covering lone surrogates or characters greater than U+FFFF, which is when the difference appears. This patch fixes those descriptions, and adds some such missing tests.