Conversation
gibson042
reviewed
Mar 24, 2025
Member
gibson042
left a comment
gibson042
left a comment
There was a problem hiding this comment.
Thanks @ryzokuken! My suggestions relate to adding more spec context and exercising more branches of the AvailableNamedTimeZoneIdentifiers algorithm.
Member
Author
|
Done! The following test fails on V8 (cc @FrankYFTang) |
gibson042
approved these changes
Mar 25, 2025
Adds a test to check the time zone canonicalization logic to verify that the new normative requirements for canonicalizing time zone introduced by ecma402#877 are implemented correctly.
Add more important test cases and improve the frontmatter to add more context from the spec. Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to check the time zone canonicalization logic to verify that the new normative requirements for canonicalizing time zone introduced by tc39/ecma402#877 are implemented correctly.
Ref: tc39/ecma402#825
Ref: unicode-org/cldr#3105
Fixes: #4363