Allow for implementation-defined Error properties#4433
Merged
Conversation
Ms2ger
approved these changes
Mar 21, 2025
Contributor
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Please add a note to the test why it's written this way
anba
force-pushed
the
supressed-error-extensions
branch
from
3817ba8 to
e776756
Compare
Contributor
Author
Done. Added the following comment: // Allow implementation-defined properties before "message" and after "suppressed". |
ljharb
approved these changes
Mar 21, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
it might be cleaner to slice keys at messageIndex for 3 total items, and compareArray, but either way is fine
Various implementations (JSC, V8, SM) define additional properties on Error instances. Adjust the test case to account for that.
Ms2ger
force-pushed
the
supressed-error-extensions
branch
from
e776756 to
3d7ace0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various implementations (JSC, V8, SM) define additional properties on Error instances. Adjust the test case to account for that.