Merged
Conversation
Contributor
|
@nicolo-ribaudo I can confirm that this fixes the tests, and that all import-defer tests pass in my branch of GraalJS now. :) |
takikawa
approved these changes
Mar 15, 2025
Contributor
takikawa
left a comment
takikawa
left a comment
There was a problem hiding this comment.
LGTM, this change makes two more tests pass on WebKit (two still fail).
ptomato
approved these changes
Apr 23, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay.
ptomato
force-pushed
the
import-defer-fixes
branch
from
4e976b3 to
904a59e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the suggestions in #4416 are correct. @woess Can you confirm that this makes the tests pass? :)
Fixes #4416