Add tests for RegExp.escape #4123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
bakkot
reviewed
Jun 28, 2024
bakkot
reviewed
Jun 28, 2024
Member
Author
|
Thanks @bakkot! I fixed some coverage. I'll have a hard stop for now but will continue later. |
leobalter
force-pushed
the
leo/regexp-escape
branch
from
26d618e to
f35878a
Compare
leobalter
force-pushed
the
leo/regexp-escape
branch
2 times, most recently
from
91dd85a to
a74928b
Compare
Member
Author
|
This should be ready for another round of reviews. |
Member
Author
|
Thanks, @ljharb! I believe I addressed all the review points so far. |
ljharb
approved these changes
Jul 5, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Took over the PR at Leo's request; PTAL
ljharb
added a commit
to es-shims/RegExp.escape
that referenced
this pull request
Jul 9, 2024
also add test262 tests from tc39/test262#4123
ljharb
force-pushed
the
leo/regexp-escape
branch
from
36e7d9e to
c097a9b
Compare
Member
|
Are these ready to merge? I'm hoping to ask for stage 3 at this month's plenary. |
Ms2ger
approved these changes
Jul 18, 2024
Ms2ger
force-pushed
the
leo/regexp-escape
branch
from
c097a9b to
807963f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of tests for RegExp.escape. I still need to review if I'm missing coverage here or running the tests.