More tests for Top Level Await #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leobalter
force-pushed
the
2218/top-level-await-first-part2
branch
4 times, most recently
from
db51745 to
981e817
Compare
leobalter
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
leobalter
commented
Aug 22, 2019
| completed += 1; | ||
| } | ||
|
|
||
| assert.sameValue(completed, 1); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
leobalter
commented
Aug 22, 2019
| features: [top-level-await, dynamic-import] | ||
| ---*/ | ||
|
|
||
| try {} catch (await e) {} |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
leobalter
force-pushed
the
2218/top-level-await-first-part2
branch
from
d284bab to
22ecbe4
Compare
leobalter
force-pushed
the
2218/top-level-await-first-part2
branch
from
51ca779 to
9d49f72
Compare
leobalter
force-pushed
the
2218/top-level-await-first-part2
branch
from
9d49f72 to
6952c3c
Compare
Member
Author
|
This is ready for review. I was able to check the tests with V8 using the TLA flag and the only failures were related to the top level |
Member
Author
|
The only missing part for TLA is checking importing modules with the TLA peaces. Otherwise, everything seems fine. I plan to add that in a follow up PR. |
rwaldron
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2218