Polyfill: Fix off-by-1-or-2s error due to FP precision loss #3173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered by comparing the snapshot tests against other implementations. h/t Tim Chevalier for figuring out where the bug was. The spec is correct, no change needed. Update the snapshots accordingly. Regression from 7b924d4.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
+ Coverage 96.91% 96.96% +0.05%
==========================================
Files 22 22
Lines 10209 10219 +10
Branches 1839 1841 +2
==========================================
+ Hits 9894 9909 +15
+ Misses 266 261 -5
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Oct 31, 2025
Bug observed in the proposal-temporal reference code, caused by improper implementation of AddTime (https://tc39.es/proposal-temporal/#sec-temporal-addtime) where the advice in Step 2 was not followed correctly. See tc39/proposal-temporal#3173
Collaborator
Author
|
Test262 tests in tc39/test262#4629 |
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Oct 31, 2025
Bug observed in the proposal-temporal reference code, caused by improper implementation of AddTime (https://tc39.es/proposal-temporal/#sec-temporal-addtime) where the advice in Step 2 was not followed correctly. See tc39/proposal-temporal#3173
Ms2ger
pushed a commit
to ptomato/test262
that referenced
this pull request
Nov 3, 2025
Bug observed in the proposal-temporal reference code, caused by improper implementation of AddTime (https://tc39.es/proposal-temporal/#sec-temporal-addtime) where the advice in Step 2 was not followed correctly. See tc39/proposal-temporal#3173
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Nov 3, 2025
Bug observed in the proposal-temporal reference code, caused by improper implementation of AddTime (https://tc39.es/proposal-temporal/#sec-temporal-addtime) where the advice in Step 2 was not followed correctly. See tc39/proposal-temporal#3173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by comparing the snapshot tests against other implementations. h/t @catamorphism for figuring out where the bug was.
The spec is correct, no change needed.
Update the snapshots accordingly.
Regression from 7b924d4.