Conversation
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
===========================================
- Coverage 95.30% 60.65% -34.65%
===========================================
Files 19 18 -1
Lines 11089 4796 -6293
Branches 1733 1045 -688
===========================================
- Hits 10568 2909 -7659
- Misses 517 1411 +894
- Partials 4 476 +472
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ptomato
force-pushed
the
1427-consume-iterables
branch
from
dc01560 to
bbffad0
Compare
ljharb
reviewed
Apr 16, 2021
ptomato
force-pushed
the
1427-consume-iterables
branch
from
bbffad0 to
e98860c
Compare
In ToTemporalDateTime and ToTemporalZonedDateTime, the polyfill did not match the spec text. The list of fields in the spec text includes the time field names. (This will be tested in a following commit.)
ptomato
force-pushed
the
1427-consume-iterables
branch
from
e98860c to
db66dea
Compare
bakkot
reviewed
Apr 16, 2021
ljharb
reviewed
Apr 16, 2021
cjtenny
approved these changes
Apr 16, 2021
ptomato
force-pushed
the
1427-consume-iterables
branch
from
db66dea to
0f61f20
Compare
ljharb
reviewed
Apr 16, 2021
The fields() methods of the built-in Temporal calendars will only ever return arrays, but this allows custom calendars to return an iterable (such as a Set.) See: #1427
Temporal will only ever call the fields() method with an array, but other callers may want to supply a different iterable (such as a Set). See: #1427
This is a bug in both the polyfill and the spec text, that is exposed by the tests added in the following commit.
The getPossibleInstantsFor() methods of the built-in Temporal time zones will only ever return arrays, but this allows custom time zones to return an iterable (such as a Set.) See: #1427
ptomato
force-pushed
the
1427-consume-iterables
branch
from
0f61f20 to
df98a24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1427