Skip to content

Normative: add Math.sumPrecise #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Normative: add Math.sumPrecise #3654

merged 1 commit into from
Aug 19, 2025

Conversation

@bakkot
Copy link
Member

@bakkot bakkot commented Jul 17, 2025

Pending stage 4.

@bakkot bakkot added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Jul 17, 2025
@bakkot bakkot mentioned this pull request Jul 17, 2025
Open
8 tasks
michaelficarra
michaelficarra reviewed Jul 17, 2025
View reviewed changes
michaelficarra
michaelficarra reviewed Jul 17, 2025
View reviewed changes
@ljharb ljharb added has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jul 17, 2025
linusg
linusg previously requested changes Jul 22, 2025
View reviewed changes
@bakkot
Copy link
Member Author

bakkot commented Jul 23, 2025

Addressed comments. I also pushed up a small tweak to how _count_ is handled to match the prevailing style as seen in e.g. the GroupBy AO.

@bakkot bakkot added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Jul 28, 2025
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Aug 18, 2025
@ljharb ljharb dismissed linusg’s stale review August 19, 2025 04:38

changes addressed

@ljharb ljharb merged commit 27172c8 into main Aug 19, 2025
8 checks passed
@ljharb ljharb deleted the sum-precise branch August 19, 2025 04:45
@Jack-Works Jack-Works mentioned this pull request Aug 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelficarra michaelficarra michaelficarra left review comments

@syg syg syg approved these changes

+1 more reviewer

@linusg linusg linusg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bakkot @syg @michaelficarra @linusg @ljharb