Merged
Conversation
ljharb
force-pushed
the
master
branch
3 times, most recently
from
3d0c24c to
7a79833
Compare
bakkot
approved these changes
Aug 23, 2021
Member
|
I'd prefer to see the Evaluation definition for BindingIdentifier moved to the main spec and just drop the definition for ForBinding, as you suggest in your commit message. Less fiddling with things in Annex B is better. |
Member
|
I notice here there's a lot of cases defined for MV that are covered by the chain rule. It'd be nice to drop those cases. edit: Not blocking this PR, of course. Feel free to add that change here or we can do it as a separate PR. |
jmdyck
force-pushed
the
fix_some_SDOs
branch
from
0b1f1ca to
0215356
Compare
Collaborator
Author
Done. (Modified the first commit.) |
Collaborator
Author
Yeah, I had been thinking of that as a separate PR, but I guess it fits okay here. I've added a commit that removes all definitions that are covered by the chain rule, but it's possible there are cases where stating the definition explicitly might be helpful to the reader, so let me know if you'd like any reinstated. |
Member
|
@jmdyck We have decided to minimise unnecessary definitions: #1933 (comment) |
michaelficarra
approved these changes
Sep 14, 2021
bakkot
added
the
ready to merge
PR tc39#614 defined (in Annex B) an additional form for ForInOfStatement. Performing ForInOfLoopEvaluation on it ends with a call to ForIn/OfBodyEvaluation, with |BindingIdentifier| as first arg, passed to the _lhs_ param. ForIn/OfBodyEvaluation (at step 6.g.i.1) evaluates this param, but there's no definition of Evaluation for |BindingIdentifier|. This PR adds the necessary definition. Rather than add it to the annex that defines the additional form of ForInOfStatement, this commit substitutes it for the (main body) definition of `Evaluation` for `ForBinding : BindingIdentifier`, allowing the latter to chain to the new definition, since it has the same semantics.
Specifically: - LexicallyDeclaredNames - LexicallyScopedDeclarations - VarDeclaredNames - VarScopedDeclarations Fixes tc39#2354.
The `Evaluation` SDO doesn't reach AsyncFunctionDeclaration; it stops at `HoistableDeclaration : AsyncFunctionDeclaration`.
…opLevelLexicallyScopedDeclarations` (tc39#2406) TopLevelLexicallyDeclaredNames is only invoked on |StatementList| and (recursively) |StatementListItem|), so it never reaches |LabelledStatement|. Ditto all that for TopLevelLexicallyScopedDeclarations. Also, TopLevelLexicallyScopedDeclarations never reaches |Block|.
…lVarScopedDeclarations` (tc39#2406) TopLevelVarDeclaredNames & TopLevelVarScopedDeclarations are invoked on |Statement|, but only when it's a |LabelledStatement|, so they never reach |BlockStatement|, let alone |Block|.
VarDeclaredNames is invoked on |ModuleItemList|, but not on |Module|.
ljharb
force-pushed
the
fix_some_SDOs
branch
from
0215356 to
0bd3ace
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
PR tc39#614 defined (in Annex B) an additional form for ForInOfStatement. Performing ForInOfLoopEvaluation on it ends with a call to ForIn/OfBodyEvaluation, with |BindingIdentifier| as first arg, passed to the _lhs_ param. ForIn/OfBodyEvaluation (at step 6.g.i.1) evaluates this param, but there's no definition of Evaluation for |BindingIdentifier|. This PR adds the necessary definition. Rather than add it to the annex that defines the additional form of ForInOfStatement, this commit substitutes it for the (main body) definition of `Evaluation` for `ForBinding : BindingIdentifier`, allowing the latter to chain to the new definition, since it has the same semantics.
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Specifically: - LexicallyDeclaredNames - LexicallyScopedDeclarations - VarDeclaredNames - VarScopedDeclarations Fixes tc39#2354.
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
The `Evaluation` SDO doesn't reach AsyncFunctionDeclaration; it stops at `HoistableDeclaration : AsyncFunctionDeclaration`.
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
…opLevelLexicallyScopedDeclarations` (tc39#2406) TopLevelLexicallyDeclaredNames is only invoked on |StatementList| and (recursively) |StatementListItem|), so it never reaches |LabelledStatement|. Ditto all that for TopLevelLexicallyScopedDeclarations. Also, TopLevelLexicallyScopedDeclarations never reaches |Block|.
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
…lVarScopedDeclarations` (tc39#2406) TopLevelVarDeclaredNames & TopLevelVarScopedDeclarations are invoked on |Statement|, but only when it's a |LabelledStatement|, so they never reach |BlockStatement|, let alone |Block|.
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
VarDeclaredNames is invoked on |ModuleItemList|, but not on |Module|.
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some needed SDO definitions.
Drop some unused SDO definitions.
Fixes #2354.