Normative: ToInteger normalizes `-0` to `+0` by ljharb · Pull Request #1827 · tc39/ecma262

ljharb · 2020-01-03T20:59:38Z

Fixes #1637.

This only has an observable impact on Atomics.store.

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

spec.html

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

anba · 2020-02-01T11:42:03Z

ToIndex should probably be changed to use SameValue instead of SameValueZero, because with the proposed changed integerIndex is never -0 and therefore we don't need the special-handling to allow integerIndex=-0 and index=+0. (ToLength(-0) returns +0, which made it necessary to use SameValueZero in ToIndex.)
Array.prototype.indexOf, step 7.a no longer needs the special-handling for -0.
Same for Array.prototype.lastIndexOf

anba

See above comment

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

Per tc39/ecma262#1827

ljharb · 2020-02-09T02:54:32Z

Tests: tc39/test262#2496

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

Per tc39/ecma262#1827

devsnek · 2020-02-15T02:36:02Z

This can still return -0 for inputs in the exclusive range -1 to 0.

ljharb · 2020-02-15T02:51:37Z

Good call; I’ll put up a bug fix.

…) to produce `-0`

…) to produce `-0` (tc39#1871)

Normative: `ToInteger`: fix spec bug from tc39#1827 that allows (-1,0) to…

PR tc39#1827 (among other things) removed step 4 from the algorithm for TimeClip, obsoleting the accompanying emu-note that describes "the point of step 4". Conceivably, the note could be reworded to describe the effect of 'ToInteger' on step 3, but I don't think it'd be worth the bother.

Editorial: Reinstate an SDO rule PR tc39#1933 deleted SDO rules that are handled by the chain production rule, but it also deleted this one which isn't. (It has "TV" on the left and "TRV" on the right.) Editorial: Move an <emu-note> element PR tc39#1490 (among other things) moved the evaluation semantics for ArrowFunction from the Evaluation SDO to the NamedEvaluation SDO. The accompanying <emu-note> should have moved at the same time (in particular because of the reference to "step 3"). Editorial: Delete <emu-note> in TimeClip clause PR tc39#1827 (among other things) removed step 4 from the algorithm for TimeClip, obsoleting the accompanying emu-note that describes "the point of step 4". Conceivably, the note could be reworded to describe the effect of 'ToInteger' on step 3, but I don't think it'd be worth the bother. Editorial: Change "Step 2.a" to "Step 2.b" in RepeatMatcher note PR tc39#1889 (among other things) inserted a step before the former 2.a, but didn't update the note that referenced it. Editorial: Change step 7 to step 6 in SortCompare note Commit 9c1e076 (2015-10-26) introduced the '?' abbreviation for ReturnIfAbrupt. This caused the ToString call on step 7 to move to step 6, but the note that referred to it wasn't updated. Editorial: Fix typo: "Descritor" -> "Descriptor" Editorial: Fix typo: "GeneratorObject" -> "generator object" (There's no such thing as a GeneratorObject.) Editorial: Delete "as a parameter" after "is present" (It's the only place in the spec where we use that phrasing.) Editorial: Change "which" to "that" ... in "{String,Array,Map,Set} methods which return such iterators" Editorial: Insert a comma in SetDefaultGlobalBindings() Formerly, it read like "containing" modified "the property", when it actually modified "the property descriptor". Editorial: Change "lexical environment" to "Environment Record" ... in FunctionDeclarationInstantiation, to balance the NOTE in the other arm of the if-else, and also for consistency with the NOTE at 27.a. (I should have done this in PR tc39#1697.) Editorial: Change "step 3" to "step 4" in Note ... that accompanies the NamedEvaluation semantics for ArrowFunction : ArrowParameters `=>` ConciseBody PR tc39#1870 (among other things) inserted a step before the former step 3, but didn't update the note that referenced it.

ljharb requested review from anba, bakkot, michaelficarra and syg January 3, 2020 20:59

ljharb added a commit to ljharb/ecma262 that referenced this pull request Jan 3, 2020

Normative: ToInteger normalizes -0 to +0 (tc39#1827)

7b67249

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

ljharb force-pushed the to-integer-neg-zero branch from 297247b to 7b67249 Compare January 3, 2020 21:00

ljharb added a commit to ljharb/ecma262 that referenced this pull request Jan 6, 2020

Normative: ToInteger normalizes -0 to +0 (tc39#1827)

b4b2cfe

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

ljharb force-pushed the to-integer-neg-zero branch from 7b67249 to b4b2cfe Compare January 6, 2020 19:03

syg reviewed Jan 8, 2020

View reviewed changes

spec.html Outdated Show resolved Hide resolved

ljharb added a commit to ljharb/ecma262 that referenced this pull request Jan 8, 2020

Normative: ToInteger normalizes -0 to +0 (tc39#1827)

b65c65b

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

ljharb force-pushed the to-integer-neg-zero branch from b4b2cfe to b65c65b Compare January 8, 2020 21:43

ExE-Boss approved these changes Jan 10, 2020

View reviewed changes

anba suggested changes Feb 1, 2020

View reviewed changes

ljharb added a commit to ljharb/ecma262 that referenced this pull request Feb 1, 2020

Normative: ToInteger normalizes -0 to +0 (tc39#1827)

ca92d09

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

ljharb force-pushed the to-integer-neg-zero branch from b65c65b to ca92d09 Compare February 1, 2020 17:39

ljharb requested a review from anba February 1, 2020 17:39

michaelficarra approved these changes Feb 4, 2020

View reviewed changes

ljharb requested a review from syg February 4, 2020 18:32

syg approved these changes Feb 4, 2020

View reviewed changes

bakkot approved these changes Feb 4, 2020

View reviewed changes

ljharb self-assigned this Feb 4, 2020

ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels Feb 5, 2020

ljharb added a commit to ljharb/test262 that referenced this pull request Feb 9, 2020

Atomics.store now normalizes -0 to +0

8ec20ad

Per tc39/ecma262#1827

ljharb mentioned this pull request Feb 9, 2020

Atomics.store now normalizes -0 to +0 tc39/test262#2496

Merged

Normative: ToInteger normalizes -0 to +0 (tc39#1827)

ddac91d

Fixes tc39#1637. This only has an observable impact on `Atomics.store`.

ljharb force-pushed the to-integer-neg-zero branch from ca92d09 to ddac91d Compare February 9, 2020 02:54

rwaldron pushed a commit to tc39/test262 that referenced this pull request Feb 13, 2020

Atomics.store now normalizes -0 to +0

a1fbd31

Per tc39/ecma262#1827

ljharb added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Feb 13, 2020

ljharb merged commit ddac91d into tc39:master Feb 13, 2020

ljharb deleted the to-integer-neg-zero branch February 13, 2020 17:44

ljharb added a commit to ljharb/ecma262 that referenced this pull request Feb 15, 2020

Normative: ToInteger: fix spec bug from tc39#1827 that allows (-1,0…

d4f4652

…) to produce `-0`

ljharb mentioned this pull request Feb 15, 2020

Normative: ToInteger: fix spec bug from #1827 that allows (-1,0) to produce -0 #1871

Merged

ljharb added a commit to ljharb/ecma262 that referenced this pull request Feb 15, 2020

Normative: ToInteger: fix spec bug from tc39#1827 that allows (-1,0…

b221da8

…) to produce `-0` (tc39#1871)

ljharb added a commit to ljharb/ecma262 that referenced this pull request Feb 15, 2020

Normative: ToInteger: fix spec bug from tc39#1827 that allows (-1,0…

b09fb0e

…) to produce `-0` (tc39#1871)

ljharb added a commit to ljharb/ecma262 that referenced this pull request Feb 15, 2020

Normative: ToInteger: fix spec bug from tc39#1827 that allows (-1,0…

8e5ae7b

…) to produce `-0` (tc39#1871)

sthagen added a commit to sthagen/tc39-ecma262 that referenced this pull request Feb 15, 2020

Merge pull request #23 from tc39/master

508cc38

Normative: `ToInteger`: fix spec bug from tc39#1827 that allows (-1,0) to…

anba mentioned this pull request Jul 14, 2020

Make LocalTZA take 't' and 'isUTC' and drop DSTA(t). #778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normative: ToInteger normalizes `-0` to `+0`#1827

Normative: ToInteger normalizes `-0` to `+0`#1827
ljharb merged 1 commit intotc39:masterfrom
ljharb:to-integer-neg-zero

ljharb commented Jan 3, 2020

Uh oh!

Uh oh!

anba commented Feb 1, 2020

Uh oh!

anba left a comment

Uh oh!

ljharb commented Feb 9, 2020

Uh oh!

devsnek commented Feb 15, 2020 •

edited

Loading

Uh oh!

ljharb commented Feb 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

ljharb commented Jan 3, 2020

Uh oh!

Uh oh!

anba commented Feb 1, 2020

Uh oh!

anba left a comment

Choose a reason for hiding this comment

Uh oh!

ljharb commented Feb 9, 2020

Uh oh!

devsnek commented Feb 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb commented Feb 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

devsnek commented Feb 15, 2020 •

edited

Loading