Skip to content

Add short circuits in league cache updates for SMB4 when using existing save game database #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbrittain merged 2 commits into from
Jul 11, 2023
Merged

Add short circuits in league cache updates for SMB4 when using existing save game database #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
563fd54
Add short circuits in league cache updates for SMB4 when using existi…
tbrittain Jul 11, 2023
bb0f0d8
Bump version to 1.5.1
tbrittain Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SMB3Explorer/SMB3Explorer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Nullable>enable</Nullable>
<UseWPF>true</UseWPF>
<IsPackable>false</IsPackable>
<Version>1.5.0</Version>
<Version>1.5.1</Version>
<Title>SMB Explorer</Title>
<Authors>Trey Brittain &lt;[email protected]&gt;</Authors>
<PackageProjectUrl>https://github.com/tbrittain/SMB3Explorer</PackageProjectUrl>
Expand Down
2 changes: 1 addition & 1 deletion SMB3Explorer/Services/DataService/DataServiceInit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public async Task<OneOf<List<Smb4LeagueSelection>, Error<string>>> EstablishDbCo
return new Error<string>("Invalid save file, missing expected tables");
}

if (_applicationContext.SelectedGame is SelectedGame.Smb3)
if (_applicationContext.SelectedGame is SelectedGame.Smb3 || !isCompressedSaveGame)
{
Log.Information("Successfully established database connection");
return new List<Smb4LeagueSelection>();
Expand Down
2 changes: 1 addition & 1 deletion SMB3Explorer/ViewModels/LandingViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ private async Task<OneOf<Success, Error>> EstablishDbConnection(string filePath,
new Exception(error.Value));
}

if (_applicationContext.SelectedGame is SelectedGame.Smb4)
if (_applicationContext.SelectedGame is SelectedGame.Smb4 && isCompressedSaveGame)
{
var leaguesInConfig = _applicationConfig.GetConfigOptions();
if (leaguesInConfig.TryPickT1(out var error2, out var configOptions))
Expand Down