-
-
Notifications
You must be signed in to change notification settings - Fork 375
feat: add WebView::set_cookie and WebView::delete_cookie
#1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package Changes Through 7cd795bThere are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
WSH032
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already tested this on Windows and Linux. I need others to help test on macOS and iOS (since I don't have a Mac 😫).
I haven't implemented the Android part because I don't know Kotlin. I think this should be left for someone else to implement.
pewsheen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I currently could only reveiw the macOS part. Overall it looks good to me, but we'll need someone to review webview2 and gtk parts.
Also, I think you might missing the same site policy in macOS? If you're not able to implement that part then I can help with that.
|
Oops, I just re-signed my commit, so now I need to force push. |
Oh okay. If it's hard to rebase on your side, you can overwrite my commit and force push. |
|
Thanks! |
|
OMG, thank you so much for the contribution! |
ref #1394
close #1511